From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.11]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0662124DCE8; Thu, 22 May 2025 23:57:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.11 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747958246; cv=none; b=o+gj+wlNNxhZ2DWaEyi3nP4CEiDW6XF9VvDE/z/d0JkzqOUBXHB3ZkawWlesvEbJ4dflBjOjQrb9RecA/27WIxL5mkwGfwiGHgi1KzL+fMKeSoHv9ozU8BtjfiRfooVVk0lfOALCXv6sFEbTTTfJtDUhkwBfipP1FHM1BKn119I= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747958246; c=relaxed/simple; bh=QYOWZ2FwAxXVY5zAUVw+08m0cpSZDQFAL7+izIDHNig=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=iHF+kcGBH/urEPk6of00AmKcAKN1bbJ0zlJlcW1r79zk/VNqGSue4fhfCwMhT5jQMKEgM5AuNbjZwYUTzYaAPZ4d4C5gwpfDDq1c8X1e10Umr6co7D6txK+DN1eajLncp1Z/oFNqiVySuPylODy9bGT3KA0nsqzHM5CX5b6HXMo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=AFZtcTbK; arc=none smtp.client-ip=192.198.163.11 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="AFZtcTbK" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1747958245; x=1779494245; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=QYOWZ2FwAxXVY5zAUVw+08m0cpSZDQFAL7+izIDHNig=; b=AFZtcTbKaMnMtDphzxx+GsHim3vTMJWvPX1S9rbbL9Ye1Zpa9u/YP9YJ Af8djXw0yjfCKX/nyntsK1MJibS+0s1FrI9MEQ7sbbcryD8I7Gw0zDddK qaZDepXmP2IwviSmmYKZzk4wl8ClwebeDI+iQYZP5diWIzfnVleJ18/Gd 2aV4l+YEG+1+mDwD0da+aBXWglV3BT5s2lDz95X5XtW4IF1Yu6uJ5S30D kquDzceXGDjhwx44rLA/+ICnGeObTW7eKB6eMU9+muv568gShLmbbezz8 hnJS4pzjPlWQsnqKCiBjTSm5q0o8frtjbwR9t5XGLa542oulyS5is2rSr A==; X-CSE-ConnectionGUID: I22QoPZpQDyXAV7/AYCT/w== X-CSE-MsgGUID: I3E6FySoR6yalJWQ3keqhw== X-IronPort-AV: E=McAfee;i="6700,10204,11441"; a="60643725" X-IronPort-AV: E=Sophos;i="6.15,307,1739865600"; d="scan'208";a="60643725" Received: from orviesa009.jf.intel.com ([10.64.159.149]) by fmvoesa105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 May 2025 16:57:24 -0700 X-CSE-ConnectionGUID: 7lIzCNAVR6qR2FCNCi9FFA== X-CSE-MsgGUID: jsNCrqeCRwuHtFu3GzGzEQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.15,307,1739865600"; d="scan'208";a="140657810" Received: from bjrankin-mobl3.amr.corp.intel.com (HELO [10.124.223.120]) ([10.124.223.120]) by orviesa009-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 May 2025 16:57:23 -0700 Message-ID: <2c79c6b5-db40-4e54-b058-a95c56f735fb@linux.intel.com> Date: Thu, 22 May 2025 16:57:22 -0700 Precedence: bulk X-Mailing-List: linux-pci@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v8 17/20] PCI/AER: Simplify add_error_device() To: Bjorn Helgaas , linux-pci@vger.kernel.org Cc: Jon Pan-Doh , Karolina Stolarek , Weinan Liu , Martin Petersen , Ben Fuller , Drew Walton , Anil Agrawal , Tony Luck , =?UTF-8?Q?Ilpo_J=C3=A4rvinen?= , Lukas Wunner , Jonathan Cameron , Sargun Dhillon , "Paul E . McKenney" , Mahesh J Salgaonkar , Oliver O'Halloran , Kai-Heng Feng , Keith Busch , Robert Richter , Terry Bowman , Shiju Jose , Dave Jiang , linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, Bjorn Helgaas References: <20250522232339.1525671-1-helgaas@kernel.org> <20250522232339.1525671-18-helgaas@kernel.org> Content-Language: en-US From: Sathyanarayanan Kuppuswamy In-Reply-To: <20250522232339.1525671-18-helgaas@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 5/22/25 4:21 PM, Bjorn Helgaas wrote: > From: Bjorn Helgaas > > Return -ENOSPC error early so the usual path through add_error_device() is > the straightline code. > > Signed-off-by: Bjorn Helgaas > --- Reviewed-by: Kuppuswamy Sathyanarayanan > drivers/pci/pcie/aer.c | 15 +++++++++------ > 1 file changed, 9 insertions(+), 6 deletions(-) > > diff --git a/drivers/pci/pcie/aer.c b/drivers/pci/pcie/aer.c > index 237741e66d28..24f0f5c55256 100644 > --- a/drivers/pci/pcie/aer.c > +++ b/drivers/pci/pcie/aer.c > @@ -816,12 +816,15 @@ EXPORT_SYMBOL_NS_GPL(pci_print_aer, "CXL"); > */ > static int add_error_device(struct aer_err_info *e_info, struct pci_dev *dev) > { > - if (e_info->error_dev_num < AER_MAX_MULTI_ERR_DEVICES) { > - e_info->dev[e_info->error_dev_num] = pci_dev_get(dev); > - e_info->error_dev_num++; > - return 0; > - } > - return -ENOSPC; > + int i = e_info->error_dev_num; > + > + if (i >= AER_MAX_MULTI_ERR_DEVICES) > + return -ENOSPC; > + > + e_info->dev[i] = pci_dev_get(dev); > + e_info->error_dev_num++; > + > + return 0; > } > > /** -- Sathyanarayanan Kuppuswamy Linux Kernel Developer