From: Vidya Sagar <vidyas@nvidia.com>
To: <treding@nvidia.com>
Cc: Bjorn Helgaas <helgaas@kernel.org>, <bhelgaas@google.com>,
<linux-tegra@vger.kernel.org>, <linux-pci@vger.kernel.org>,
<kthota@nvidia.com>, <mmaddireddy@nvidia.com>,
<robh+dt@kernel.org>, <devicetree@vger.kernel.org>
Subject: Re: [PATCH V3 0/2] Tegra PCIe end point config space map code refactoring
Date: Mon, 20 Nov 2017 15:57:18 +0530 [thread overview]
Message-ID: <2d2ec183-c14c-1eb8-0cd5-fd62d8b36779@nvidia.com> (raw)
In-Reply-To: <20171106195123.GG31930@bhelgaas-glaptop.roam.corp.google.com>
Thierry, Can you please Ack it so that we can target it for next release?
On Tuesday 07 November 2017 01:21 AM, Bjorn Helgaas wrote:
> On Tue, Oct 24, 2017 at 03:15:12PM -0500, Bjorn Helgaas wrote:
>> On Tue, Oct 24, 2017 at 12:14:47PM +0530, Vidya Sagar wrote:
>>> PCIe host controller in Tegra SoCs has 1GB of aperture available
>>> for mapping end points config space, IO and BARs. In that, currently
>>> 256MB is being reserved for mapping end points configuration space
>>> which leaves less memory space available for mapping end points BARs
>>> on some of the platforms.
>>> This patch series attempts to map only 4K space from 1GB aperture to
>>> access end points configuration space.
>>>
>>> Currently, this change can benefit T20 and T186 in saving (i.e. repurposed
>>> to use for BAR mapping) physical space as well as kernel virtual mapping space,
>>> it saves only kernel virtual address space in T30, T124, T132 and T210.
>>>
>>> NOTE: Since T186 PCIe DT entry is not yet present in main line (it is currently
>>> merged to 'for-4.15/arm64/dt' branch), nothing gets broken with this change for T186.
>>> For older platforms (T20, T30, T124, T132, T210), this change works fine without any
>>> DT modifications
>>>
>>> Testing Done on T124, T210 & T186:
>>> Enumeration and basic functionality of immediate devices
>>> Enumeration of devices behind a PCIe switch
>>> Complete 4K configuration space access
>>>
>>> Vidya Sagar (2):
>>> PCI: tegra: refactor config space mapping code
>>> ARM64: tegra: limit PCIe config space mapping to 4K for T186
>>>
>>> arch/arm64/boot/dts/nvidia/tegra186.dtsi | 8 +-
>>> drivers/pci/host/pci-tegra.c | 125 ++++++++++---------------------
>>> 2 files changed, 44 insertions(+), 89 deletions(-)
>> Seems OK to me; waiting for Thierry's ack.
> Dropping for lack of an ack. Please repost if/when Thierry acks it.
next prev parent reply other threads:[~2017-11-20 10:27 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-24 6:44 [PATCH V3 0/2] Tegra PCIe end point config space map code refactoring Vidya Sagar
2017-10-24 6:44 ` [PATCH V3 1/2] PCI: tegra: refactor config space mapping code Vidya Sagar
2017-10-24 6:44 ` [PATCH V3 2/2] ARM64: tegra: limit PCIe config space mapping to 4K for T186 Vidya Sagar
2017-10-24 20:15 ` [PATCH V3 0/2] Tegra PCIe end point config space map code refactoring Bjorn Helgaas
2017-11-06 19:51 ` Bjorn Helgaas
2017-11-20 10:27 ` Vidya Sagar [this message]
-- strict thread matches above, loose matches on Subject: below --
2017-12-04 17:53 Vidya Sagar
2017-12-11 10:54 ` Thierry Reding
2017-12-11 17:54 ` Bjorn Helgaas
2017-12-12 11:01 ` Lorenzo Pieralisi
2017-12-12 12:22 ` Thierry Reding
2017-12-14 10:37 ` Lorenzo Pieralisi
2017-12-14 14:01 ` Thierry Reding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2d2ec183-c14c-1eb8-0cd5-fd62d8b36779@nvidia.com \
--to=vidyas@nvidia.com \
--cc=bhelgaas@google.com \
--cc=devicetree@vger.kernel.org \
--cc=helgaas@kernel.org \
--cc=kthota@nvidia.com \
--cc=linux-pci@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=mmaddireddy@nvidia.com \
--cc=robh+dt@kernel.org \
--cc=treding@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).