From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PULL_REQUEST,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B703DC48BD6 for ; Wed, 26 Jun 2019 15:22:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8A12A205C9 for ; Wed, 26 Jun 2019 15:22:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726157AbfFZPWR (ORCPT ); Wed, 26 Jun 2019 11:22:17 -0400 Received: from szxga05-in.huawei.com ([45.249.212.191]:19115 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725958AbfFZPWR (ORCPT ); Wed, 26 Jun 2019 11:22:17 -0400 Received: from DGGEMS403-HUB.china.huawei.com (unknown [172.30.72.60]) by Forcepoint Email with ESMTP id CED06C1ABC82D47A8304; Wed, 26 Jun 2019 23:22:13 +0800 (CST) Received: from [127.0.0.1] (10.202.227.238) by DGGEMS403-HUB.china.huawei.com (10.3.19.203) with Microsoft SMTP Server id 14.3.439.0; Wed, 26 Jun 2019 23:22:06 +0800 Subject: Re: [GIT PULL] Hisilicon fixes for v5.2 To: Olof Johansson , Wei Xu References: <20190625112148.ckj7sgdgvyeel7vy@localhost> <7e215bd7-daab-b6cf-8d0f-9513bd7c4f6d@huawei.com> CC: ARM-SoC Maintainers , linux-arm-kernel , Arnd Bergmann , Linuxarm , "xuwei (O)" , "Bjorn Helgaas" , , "Rafael J. Wysocki" , Linux Kernel Mailing List , Zhangyi ac , "Liguozhu (Kenneth)" , , huangdaode , Tangkunshan , Jonathan Cameron , Shameerali Kolothum Thodi , Shiju Jose , Salil Mehta From: John Garry Message-ID: <2e59728e-25fa-cc15-3c63-3566dc2ae69f@huawei.com> Date: Wed, 26 Jun 2019 16:21:56 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 MIME-Version: 1.0 In-Reply-To: <7e215bd7-daab-b6cf-8d0f-9513bd7c4f6d@huawei.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.202.227.238] X-CFilter-Loop: Reflected Sender: linux-pci-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org On 25/06/2019 14:31, John Garry wrote: > On 25/06/2019 14:03, Olof Johansson wrote: >>>> are available in the Git repository at: >>>> > > >>>> > > git://github.com/hisilicon/linux-hisi.git tags/hisi-fixes-for-5.2 >>>> > > >>>> > > for you to fetch changes up to >>>> 07c811af1c00d7b4212eac86900b023b6405a954: >>>> > > >>>> > > lib: logic_pio: Enforce LOGIC_PIO_INDIRECT region ops are set >>>> at registration (2019-06-25 09:40:42 +0100) >>>> > > >>>> > > ---------------------------------------------------------------- >>>> > > Hisilicon fixes for v5.2-rc >>>> > > >>>> > > - fixed RCU usage in logical PIO >>>> > > - Added a function to unregister a logical PIO range in logical PIO >>>> > > to support the fixes in the hisi-lpc driver >>>> > > - fixed and optimized hisi-lpc driver to avoid potential >>>> use-after-free >>>> > > and driver unbind crash >>> > >>> > Merged to fixes, thanks. >> >> This broke arm64 allmodconfig: >> >> arm64.allmodconfig: >> drivers/bus/hisi_lpc.c:656:3: error: implicit declaration of function >> 'hisi_lpc_acpi_remove'; did you mean 'hisi_lpc_acpi_probe'? >> [-Werror=implicit-function-declaration] As an aside, I find it a little strange that arm64 allmodconfig does not have CONFIG_ACPI set. It used to have it set, and this patch stopped that: 5bcd44083a082f314032969cd6db1eb8275ac77a is the first bad commit commit 5bcd44083a082f314032969cd6db1eb8275ac77a Author: AKASHI Takahiro Date: Mon Jul 23 10:57:29 2018 +0900 drivers: acpi: add dependency of EFI for arm64 As Ard suggested, CONFIG_ACPI && !CONFIG_EFI doesn't make sense on arm64, while CONFIG_ACPI and CONFIG_CPU_BIG_ENDIAN doesn't make sense either. As CONFIG_EFI already has a dependency of !CONFIG_CPU_BIG_ENDIAN, it is good enough to add a dependency of CONFIG_EFI to avoid any useless combination of configuration. This bug, reported by Will, will be revealed when my patch series, "arm64: kexec,kdump: fix boot failures on acpi-only system," is applied and the kernel is built under allmodconfig. Signed-off-by: AKASHI Takahiro Suggested-by: Ard Biesheuvel Signed-off-by: Will Deacon That patch stopped many configs being set for allmodconfig. With this change, CONFIG_EFI is not set. I think that this is because CONFIG_CPU_BIG_ENDIAN is set for arm64 allmodconfig. Any opinion on this? Could we change CONFIG_CPU_BIG_ENDIAN to be unset for arm64? >> >> > > Uhhh, that's my fault - I didn't provide a stub for !ACPI. Sorry. I'll > send a fixed v3 series. > >> >> Please build and test your branches before you send pull requests, Wei. >> >> I've dropped the branch again; please re-submit when fixed. I think >> it's probably 5.3 material now. >> > > Thanks, > John > >> >> -Olof >> >> . >> >