From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Return-Path: Subject: Re: [RFC PATCH] efi/fb: Convert PCI bus address to resource if translated by the bridge To: Sinan Kaya , linux-pci@vger.kernel.org References: <1526495029-25783-1-git-send-email-okaya@codeaurora.org> From: Timur Tabi Message-ID: <3120434b-9831-bf33-25b8-11aba1c1b648@codeaurora.org> Date: Wed, 16 May 2018 13:31:54 -0500 MIME-Version: 1.0 In-Reply-To: <1526495029-25783-1-git-send-email-okaya@codeaurora.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "open list:EFIFB FRAMEBUFFER DRIVER" , Bartlomiej Zolnierkiewicz , linux-arm-msm@vger.kernel.org, open list , "open list:FRAMEBUFFER LAYER" , Peter Jones , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+bjorn=helgaas.com@lists.infradead.org List-ID: On 05/16/2018 01:23 PM, Sinan Kaya wrote: > + win_start = window->res->start - window->offset; Can you guarantee that window->res->start is always >= window->offset? > + win_size = window->res->end - window->res->start + 1; Use resource_size() instead. -- Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm Technologies, Inc. Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel