From: "Derrick, Jonathan" <jonathan.derrick@intel.com>
To: "vicamo.yang@canonical.com" <vicamo.yang@canonical.com>
Cc: "lorenzo.pieralisi@arm.com" <lorenzo.pieralisi@arm.com>,
"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
"helgaas@kernel.org" <helgaas@kernel.org>,
"kai.heng.feng@canonical.com" <kai.heng.feng@canonical.com>
Subject: Re: [PATCH] PCI: vmd: Allow VMD PM to use PCI core PM code
Date: Wed, 5 Aug 2020 15:30:00 +0000 [thread overview]
Message-ID: <31275a25f29cad2fbda49f94839e128afc15acee.camel@intel.com> (raw)
In-Reply-To: <7a46dec4-20a4-27d4-ae3d-f428608813e4@canonical.com>
On Wed, 2020-08-05 at 15:54 +0800, You-Sheng Yang wrote:
> On 2020-08-01 01:15, Jon Derrick wrote:
> > The pci_save_state call in vmd_suspend can be performed by
> > pci_pm_suspend_irq. This allows the call to pci_prepare_to_sleep into
> > ASPM flow.
> >
> > The pci_restore_state call in vmd_resume was restoring state after
> > pci_pm_resume->pci_restore_standard_config had already restored state.
> > It's also been suspected that the config state should be restored before
> > re-requesting IRQs.
> >
> > Remove the pci_{save,restore}_state calls in vmd_{suspend,resume} in
> > order to allow proper flow through PCI core power management ASPM code.
>
> I had a try on this patch but `lspci` still shows ASPM Disabled.
> Anything prerequisite missing here?
>
Is enabling L0s/L1/etc on a device something that the driver should be
doing?
Does the state change with pcie_aspm.policy=powersave ?
> You-Sheng Yang
>
next prev parent reply other threads:[~2020-08-05 15:45 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-31 17:15 [PATCH] PCI: vmd: Allow VMD PM to use PCI core PM code Jon Derrick
2020-08-05 7:54 ` You-Sheng Yang
2020-08-05 15:30 ` Derrick, Jonathan [this message]
2020-08-05 15:35 ` Bjorn Helgaas
2020-08-05 15:09 ` Bjorn Helgaas
2020-08-05 16:09 ` Derrick, Jonathan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=31275a25f29cad2fbda49f94839e128afc15acee.camel@intel.com \
--to=jonathan.derrick@intel.com \
--cc=helgaas@kernel.org \
--cc=kai.heng.feng@canonical.com \
--cc=linux-pci@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=vicamo.yang@canonical.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox