linux-pci.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Arnd Bergmann" <arnd@arndb.de>
To: "Larry Finger" <Larry.Finger@lwfinger.net>,
	"Arnd Bergmann" <arnd@kernel.org>,
	"Dominik Brodowski" <linux@dominikbrodowski.net>,
	linux-kernel@vger.kernel.org
Cc: "Bjorn Helgaas" <bhelgaas@google.com>,
	"Florian Fainelli" <f.fainelli@gmail.com>,
	"Hartley Sweeten" <hsweeten@visionengravers.com>,
	"Ian Abbott" <abbotti@mev.co.uk>,
	"Jakub Kicinski" <kuba@kernel.org>,
	"Kevin Cernekee" <cernekee@gmail.com>,
	"Lukas Wunner" <lukas@wunner.de>,
	"Manuel Lauss" <manuel.lauss@gmail.com>,
	"Oliver Hartkopp" <socketcan@hartkopp.net>,
	"Olof Johansson" <olof@lixom.net>,
	"Robert Jarzmik" <robert.jarzmik@free.fr>,
	"YOKOTA Hiroshi" <yokota@netlab.is.tsukuba.ac.jp>,
	bcm-kernel-feedback-list@broadcom.com,
	linux-arm-kernel@lists.infradead.org, linux-can@vger.kernel.org,
	linux-mips@vger.kernel.org, linux-pci@vger.kernel.org,
	linux-wireless@vger.kernel.org, Netdev <netdev@vger.kernel.org>
Subject: Re: [RFC 0/6] pcmcia: separate 16-bit support from cardbus
Date: Tue, 28 Feb 2023 09:37:21 +0100	[thread overview]
Message-ID: <31fee002-db3b-43d9-b8bc-5a869516c2d7@app.fastmail.com> (raw)
In-Reply-To: <18be9b45-e7c1-9f81-afeb-3e0d4cfe5f73@lwfinger.net>

On Tue, Feb 28, 2023, at 04:57, Larry Finger wrote:
> On 2/27/23 15:30, Arnd Bergmann wrote:
>
> It was a configuration problem. In the .config obtained by installing 
> your 
> patches, and doing a make, CONFIG_CARDBUS was not mentioned, and 
> CONFIG_PCI_HOTPLUG was not selected. When I deleted the reference to 
> the latter, 
> did a make, and set ..._HOTPLUG, I got CONFIG+CARDBUS set to "m", and 
> the yenta 
> modules were built. This version sees the BCM4318 in the lspci scan, 
> and the 
> interface works. Your patches are OK.

Ok, great, thanks for testing!

> I am not sure how to warn people about the configuration change possible 
> breaking things.

My intention was to keep Cardbus support working with old defconfig files,
and I've not moved CONFIG_CARDBUS into a separate submenu between
CONFIG_PCI_HOTPLUG and CONFIG_PCI_CONTROLLER but left the driver in
drivers/pci/hotplug. I think that's the best compromise here, but maybe
the PCI maintainers have a better idea.

     Arnd

  reply	other threads:[~2023-02-28  8:37 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-27 13:34 [RFC 0/6] pcmcia: separate 16-bit support from cardbus Arnd Bergmann
2023-02-27 13:34 ` [RFC 1/6] pccard: remove bcm63xx socket driver Arnd Bergmann
2023-02-27 21:33   ` Florian Fainelli
2023-03-14  8:53     ` Maxime Bizon
2023-02-27 13:34 ` [RFC 2/6] pccard: split cardbus support from pcmcia Arnd Bergmann
2023-02-27 13:34 ` [RFC 4/6] yenta_socket: remove dead code Arnd Bergmann
2023-02-27 13:34 ` [RFC 5/6] pccard: drop remnants of cardbus support Arnd Bergmann
2023-02-27 13:34 ` [RFC 6/6] pci: hotplug: move cardbus code from drivers/pcmcia Arnd Bergmann
2023-02-27 19:07 ` [RFC 0/6] pcmcia: separate 16-bit support from cardbus Oliver Hartkopp
2023-02-27 19:53   ` Arnd Bergmann
2023-02-27 20:32     ` Oliver Hartkopp
2023-02-27 20:54       ` Marc Kleine-Budde
2023-02-27 20:15 ` Russell King (Oracle)
2023-02-27 21:04   ` Arnd Bergmann
2023-02-28 22:45   ` David Laight
2023-02-28 22:55     ` David Laight
2023-02-27 20:23 ` Larry Finger
2023-02-27 20:38   ` Arnd Bergmann
2023-02-27 20:59     ` Russell King (Oracle)
2023-02-27 21:09     ` Larry Finger
2023-02-27 21:30       ` Arnd Bergmann
2023-02-28  3:57         ` Larry Finger
2023-02-28  8:37           ` Arnd Bergmann [this message]
2023-03-01  1:13             ` Larry Finger
2023-03-01  8:01               ` Arnd Bergmann
2023-02-28 21:35 ` Ondrej Zary

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=31fee002-db3b-43d9-b8bc-5a869516c2d7@app.fastmail.com \
    --to=arnd@arndb.de \
    --cc=Larry.Finger@lwfinger.net \
    --cc=abbotti@mev.co.uk \
    --cc=arnd@kernel.org \
    --cc=bcm-kernel-feedback-list@broadcom.com \
    --cc=bhelgaas@google.com \
    --cc=cernekee@gmail.com \
    --cc=f.fainelli@gmail.com \
    --cc=hsweeten@visionengravers.com \
    --cc=kuba@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-can@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mips@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linux@dominikbrodowski.net \
    --cc=lukas@wunner.de \
    --cc=manuel.lauss@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=olof@lixom.net \
    --cc=robert.jarzmik@free.fr \
    --cc=socketcan@hartkopp.net \
    --cc=yokota@netlab.is.tsukuba.ac.jp \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).