From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A3071C41513 for ; Tue, 15 Aug 2023 10:16:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235048AbjHOKPv (ORCPT ); Tue, 15 Aug 2023 06:15:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56400 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236406AbjHOKPR (ORCPT ); Tue, 15 Aug 2023 06:15:17 -0400 Received: from ex01.ufhost.com (ex01.ufhost.com [61.152.239.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 04235E63; Tue, 15 Aug 2023 03:15:15 -0700 (PDT) Received: from EXMBX165.cuchost.com (unknown [175.102.18.54]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "EXMBX165", Issuer "EXMBX165" (not verified)) by ex01.ufhost.com (Postfix) with ESMTP id 7B80F24E271; Tue, 15 Aug 2023 18:15:04 +0800 (CST) Received: from EXMBX171.cuchost.com (172.16.6.91) by EXMBX165.cuchost.com (172.16.6.75) with Microsoft SMTP Server (TLS) id 15.0.1497.42; Tue, 15 Aug 2023 18:15:04 +0800 Received: from [192.168.125.127] (183.27.98.20) by EXMBX171.cuchost.com (172.16.6.91) with Microsoft SMTP Server (TLS) id 15.0.1497.42; Tue, 15 Aug 2023 18:15:02 +0800 Message-ID: <34c8ac7f-243f-ed15-6f93-3d153b6315b5@starfivetech.com> Date: Tue, 15 Aug 2023 18:15:02 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.14.0 Subject: Re: [PATCH v3 08/11] PCI: microchip: Move IRQ init functions to pcie-plda-host.c Content-Language: en-US To: Conor Dooley CC: Daire McNamara , Conor Dooley , Rob Herring , Krzysztof Kozlowski , Bjorn Helgaas , Lorenzo Pieralisi , =?UTF-8?Q?Krzysztof_Wilczy=c5=84ski?= , Emil Renner Berthing , , , , , =?UTF-8?Q?Pali_Roh=c3=a1r?= , Paul Walmsley , Palmer Dabbelt , Albert Ou , Philipp Zabel , Mason Huo , Leyfoon Tan , Kevin Xie References: <20230814082016.104181-1-minda.chen@starfivetech.com> <20230814082016.104181-9-minda.chen@starfivetech.com> <20230814-everglade-nibble-af545e75b635@wendy> From: Minda Chen In-Reply-To: <20230814-everglade-nibble-af545e75b635@wendy> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [183.27.98.20] X-ClientProxiedBy: EXCAS066.cuchost.com (172.16.6.26) To EXMBX171.cuchost.com (172.16.6.91) X-YovoleRuleAgent: yovoleflag Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org On 2023/8/14 21:57, Conor Dooley wrote: > On Mon, Aug 14, 2023 at 04:20:13PM +0800, Minda Chen wrote: >> Move IRQ init functions to pcie-plda-host.c. mc_handle_event >> merge to plda_handle_event, Add get_events functions, >> PolarFire PCIe uses get_events function pointer to get >> their events num. > > Just a nit, could you add the () when referring to functions in > changelogs please? > Other than the comment I left on the last patch, this looks fine to me, > but I'd definitely like Daire to take a look at these patches that > modify the interrupt handling. OK, Thanks.