From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: From: "Rafael J. Wysocki" To: Bjorn Helgaas Cc: "lan,Tianyu" , Len Brown , "linux-acpi@vger.kernel.org" , "linux-pci@vger.kernel.org" , Alan Stern Subject: Re: [PATCH] PCI/ACPI: Change dev_info() to dev_dbg() in the acpi_pci_set_power_state() Date: Wed, 31 Jul 2013 01:31:33 +0200 Message-ID: <3509301.e8ST4r5R4A@vostro.rjw.lan> In-Reply-To: References: <1375151550-28632-1-git-send-email-tianyu.lan@intel.com> <8048720.q4LxpIqNkE@vostro.rjw.lan> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Sender: linux-acpi-owner@vger.kernel.org List-ID: On Tuesday, July 30, 2013 09:40:18 AM Bjorn Helgaas wrote: > On Tue, Jul 30, 2013 at 7:59 AM, Rafael J. Wysocki wrote: > > On Tuesday, July 30, 2013 10:32:30 AM tianyu.lan@intel.com wrote: > >> From: Lan Tianyu > >> > >> acpi_pci_set_power_state() produces log of device power state changing. > >> Now the log is produced by dev_info(). This seems make no sense when user > >> doesn't open debug option. So change it to dev_dbg() and prevent kernel > >> log from being. > >> > >> Reference: https://bugzilla.kernel.org/show_bug.cgi?id=60636 > >> Suggested-by: Alan Stern > >> Signed-off-by: Lan Tianyu > > > > Bjorn, what do you think about this? > > It's fine with me. For information that I want in the dmesg log all > the time, with no special action from the user, I personally avoid > dev_dbg() because I can never figure out whether it's enabled or not. > But I don't use the information from this printk, so it's completely > up to you. Just let me know what you want. If you have other pending > changes to this file, you can take it, or I can put it in my tree. Yes, I have one change to this file in my queue for 3.12, so I can take this patch. Thanks, Rafael > >> --- > >> drivers/pci/pci-acpi.c | 2 +- > >> 1 file changed, 1 insertion(+), 1 deletion(-) > >> > >> diff --git a/drivers/pci/pci-acpi.c b/drivers/pci/pci-acpi.c > >> index c78cc43..fb3522957 100644 > >> --- a/drivers/pci/pci-acpi.c > >> +++ b/drivers/pci/pci-acpi.c > >> @@ -210,7 +210,7 @@ static int acpi_pci_set_power_state(struct pci_dev *dev, pci_power_t state) > >> } > >> > >> if (!error) > >> - dev_info(&dev->dev, "power state changed by ACPI to %s\n", > >> + dev_dbg(&dev->dev, "power state changed by ACPI to %s\n", > >> acpi_power_state_string(state_conv[state])); > >> > >> return error; > >> > > -- > > I speak only for myself. > > Rafael J. Wysocki, Intel Open Source Technology Center. -- I speak only for myself. Rafael J. Wysocki, Intel Open Source Technology Center.