linux-pci.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Joao Pinto <Joao.Pinto@synopsys.com>
To: Marc Zyngier <marc.zyngier@arm.com>,
	Joao Pinto <Joao.Pinto@synopsys.com>, <kishon@ti.com>,
	<bhelgaas@google.com>, <jingoohan1@gmail.com>
Cc: <linux-pci@vger.kernel.org>
Subject: Re: [RFC] pci: using new interrupt API to enable MSI and MSI-X
Date: Mon, 8 May 2017 11:24:30 +0100	[thread overview]
Message-ID: <39dba8bd-dbb7-3c2e-879b-78cf3bc463c8@synopsys.com> (raw)
In-Reply-To: <c53eb6ec-14da-9bae-002b-6abc95c62b1e@arm.com>

Às 11:22 AM de 5/8/2017, Marc Zyngier escreveu:
> On 08/05/17 10:59, Joao Pinto wrote:
>> Às 3:57 PM de 5/5/2017, Marc Zyngier escreveu:
>>> Joao,
>>>
>>> On 05/05/17 15:11, Joao Pinto wrote:
>>>> Hello,
>>>> I am currently adding the support for both MSI and MSI-x in pcie-designware and
>>>> I am now facing a dificulty.
>>>>
>>>> My test endpoint is a USB 3.1 MSI / MSI-X capable and I tested that with
>>>> the changes introduced by this patch we are able to enable MSI and MSI-X
>>>> in this endpoint (depends on the usage of the MSI_FLAG_PCI_MSIX flag).
>>>>
>>>> The problem I am facing now is that Intc for the USB 3.1 Endpoint is completely
>>>> bogus (524288) when it should be 1, and so I am not receiving any interrupts
>>>> from the endpoint.
>>>
>>> It is not bogus at all. It is computed from the PCI requester ID in 
>>> pci_msi_domain_calc_hwirq. What you're seeing is the PCI/MDI domain 
>>> view of that interrupt, which is completely virtual.
>>>
>>> The real thing happens in your own irqdomain, where the hwirq for IRQ46 
>>> is probably 1 (only you can know that). As for why it doesn't work, see 
>>> below:
>>>
>>>>
>>>> I would apreciate that more experienced people in this interrupt subject could
>>>> give me an hint.
> 
> [...]
> 
>> Yep makes perfectly sense and thanks for clearing the Domains :), I understood
>> them now.
> 
> I guess that you have your MSI controller working with MSI-X now?

I started working one hour ago and still putting some subjects in order, I am
going to return to PCI in a bit. I will keep you updated. I thought you were in
US Pacific timezone.

Thanks,
Joao

> 
> Thanks,
> 
> 	M.
> 

  reply	other threads:[~2017-05-08 10:24 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-05 14:11 [RFC] pci: using new interrupt API to enable MSI and MSI-X Joao Pinto
2017-05-05 14:57 ` Marc Zyngier
2017-05-05 15:12   ` Joao Pinto
2017-05-05 15:54   ` Joao Pinto
2017-05-06 12:45     ` Marc Zyngier
2017-05-08  9:59   ` Joao Pinto
2017-05-08 10:22     ` Marc Zyngier
2017-05-08 10:24       ` Joao Pinto [this message]
2017-05-08 10:59         ` Marc Zyngier
2017-05-08 14:40           ` Joao Pinto
2017-05-08 14:49             ` Marc Zyngier
2017-05-08 15:14               ` Joao Pinto

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=39dba8bd-dbb7-3c2e-879b-78cf3bc463c8@synopsys.com \
    --to=joao.pinto@synopsys.com \
    --cc=bhelgaas@google.com \
    --cc=jingoohan1@gmail.com \
    --cc=kishon@ti.com \
    --cc=linux-pci@vger.kernel.org \
    --cc=marc.zyngier@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).