From: Christian Bruel <christian.bruel@foss.st.com>
To: Manivannan Sadhasivam <mani@kernel.org>
Cc: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>,
<lpieralisi@kernel.org>, <kw@linux.com>, <robh@kernel.org>,
<bhelgaas@google.com>, <krzk+dt@kernel.org>,
<conor+dt@kernel.org>, <mcoquelin.stm32@gmail.com>,
<alexandre.torgue@foss.st.com>, <p.zabel@pengutronix.de>,
<thippeswamy.havalige@amd.com>, <shradha.t@samsung.com>,
<quic_schintav@quicinc.com>, <cassel@kernel.org>,
<johan+linaro@kernel.org>, <linux-pci@vger.kernel.org>,
<devicetree@vger.kernel.org>,
<linux-stm32@st-md-mailman.stormreply.com>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v8 2/9] PCI: stm32: Add PCIe host support for STM32MP25
Date: Wed, 4 Jun 2025 18:35:49 +0200 [thread overview]
Message-ID: <3c7da784-e58e-4acd-a37f-93020796c0e7@foss.st.com> (raw)
In-Reply-To: <q4rbaadr7amsrtwaeickdjmcst77onuopir5rzpvixa7ow7udk@txwsmidjs3im>
>>>>>> +
>>>>>> + ret = devm_pm_runtime_enable(dev);
>>>>>> + if (ret < 0) {
>>>>>> + dev_err(dev, "Failed to enable runtime PM %d\n", ret);
>>>>>> + return ret;
>>>>>> + }
>>>>>> +
>>>>>> + pm_runtime_get_noresume(dev);
>>>>>> +
>>>>>
>>>>> I know that a lot of the controller drivers do this for no obvious reason. But
>>>>> in this case, I believe you want to enable power domain or genpd before
>>>>> registering the host bridge. Is that right?
>>>>
...
Runtime PM was broken in version 6.6 without pm_runtime_get_noresume()
On the 6.15 baseline, without this call, pm_genpd_summary reports the
correct information: active when a device is plugged, and suspended when not
So, I can proceed without pm_runtime_get_noresume(), as you mentioned in
your review.
I suspect the other platforms might have this call for the same
historical reasons.
thank you,
Christian
next prev parent reply other threads:[~2025-06-04 16:53 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-23 9:01 [PATCH v8 0/9] Add STM32MP25 PCIe drivers Christian Bruel
2025-04-23 9:01 ` [PATCH v8 1/9] dt-bindings: PCI: Add STM32MP25 PCIe Root Complex bindings Christian Bruel
2025-04-23 9:01 ` [PATCH v8 2/9] PCI: stm32: Add PCIe host support for STM32MP25 Christian Bruel
2025-04-30 7:30 ` Manivannan Sadhasivam
2025-05-12 15:08 ` Christian Bruel
2025-05-15 11:29 ` Manivannan Sadhasivam
2025-05-16 8:37 ` Christian Bruel
2025-05-16 14:52 ` Manivannan Sadhasivam
2025-06-04 16:35 ` Christian Bruel [this message]
2025-04-23 9:01 ` [PATCH v8 3/9] dt-bindings: PCI: Add STM32MP25 PCIe Endpoint bindings Christian Bruel
2025-04-23 9:01 ` [PATCH v8 4/9] PCI: stm32: Add PCIe Endpoint support for STM32MP25 Christian Bruel
2025-04-30 7:50 ` Manivannan Sadhasivam
2025-05-12 16:06 ` Christian Bruel
2025-05-15 11:26 ` Manivannan Sadhasivam
2025-05-16 12:07 ` Christian Bruel
2025-04-23 9:01 ` [PATCH v8 5/9] MAINTAINERS: add entry for ST STM32MP25 PCIe drivers Christian Bruel
2025-04-23 9:01 ` [PATCH v8 6/9] arm64: dts: st: add PCIe pinctrl entries in stm32mp25-pinctrl.dtsi Christian Bruel
2025-04-23 9:01 ` [PATCH v8 7/9] arm64: dts: st: Add PCIe Root Complex mode on stm32mp251 Christian Bruel
2025-04-23 9:01 ` [PATCH v8 8/9] arm64: dts: st: Add PCIe Endpoint " Christian Bruel
2025-04-23 9:01 ` [PATCH v8 9/9] arm64: dts: st: Enable PCIe on the stm32mp257f-ev1 board Christian Bruel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3c7da784-e58e-4acd-a37f-93020796c0e7@foss.st.com \
--to=christian.bruel@foss.st.com \
--cc=alexandre.torgue@foss.st.com \
--cc=bhelgaas@google.com \
--cc=cassel@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=johan+linaro@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=kw@linux.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=lpieralisi@kernel.org \
--cc=mani@kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=mcoquelin.stm32@gmail.com \
--cc=p.zabel@pengutronix.de \
--cc=quic_schintav@quicinc.com \
--cc=robh@kernel.org \
--cc=shradha.t@samsung.com \
--cc=thippeswamy.havalige@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).