From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx07-00178001.pphosted.com (mx08-00178001.pphosted.com [91.207.212.93]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 095AF1D619F; Wed, 4 Jun 2025 16:53:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.207.212.93 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749055995; cv=none; b=hEbiNaNE4fDKWYQYl9rRC7sTfb29JoWZt3CwIm9m9xiqh4qUfZpCKLLa54P4gW2+Qr7oQfpF/B55+FmwW992ZJJ0prdrRHOUZL1/e2N1tRYVOtXQFbNL4zSaPf9eUVlr46oYCAMnSjBR+kzZPsnQnL85NqkNqZLLnCnudA2hO1A= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749055995; c=relaxed/simple; bh=Wuj00UCDsD3DRRwGoINhagwJ5TSoXk+8da3/MXsZGlo=; h=Message-ID:Date:MIME-Version:From:Subject:To:CC:References: In-Reply-To:Content-Type; b=MpwcnQK+//kOBk0cYjSmrCHL6yIDz6LaQoaAeII/s/CSIp9KuHTgFsoi2DHDZc7mOkWjHFSoF0LIBFHz2EZ1p6UCa0E1Twj3XFz8GMv+rjOyJ7rLDErG6fU+/1bn0x8tm6ogpE3BJsna1LboFt4QvSdAW4cUsMGdJ2MmTlv/Q+8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=foss.st.com; spf=pass smtp.mailfrom=foss.st.com; dkim=pass (2048-bit key) header.d=foss.st.com header.i=@foss.st.com header.b=mSugKeI2; arc=none smtp.client-ip=91.207.212.93 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=foss.st.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=foss.st.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=foss.st.com header.i=@foss.st.com header.b="mSugKeI2" Received: from pps.filterd (m0046661.ppops.net [127.0.0.1]) by mx07-00178001.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 554F7slN011211; Wed, 4 Jun 2025 18:39:21 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foss.st.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=selector1; bh= 0BbnVS9D20ezMI4EQTDWMDtbyTWlsW9ZoYQZlC7MMog=; b=mSugKeI2mDPxVCh1 HeGvrpJFummrgU1JBzlCbO6Inv6ABcTf1xTboAGXebQ4Va750dqiRf4t7gDXvgcp WylEgtUpxhieyEkf9TNCZeZoPe6Oc0DQBD9JmAUCQhNLPztUPazCLOGgUSCwHoFx 2DEIoVPRSjgIfJOTjizbCsMG3KTVl44wQGE/Czla21dwM++eZZ3DCb6d+lJIvmbe 7mk7Y+PWPbC9AyIhOGtgRr6A9yIhAfXzbVA3BODhITE/zm00qhRKH0LI8SVW+PEU arW8pHI5Jvm538mPnHgbSljWUwKisScM0COJ7pIgjE2Zslf6i4LMPz9yNWd4H4ug qgA7Lg== Received: from beta.dmz-ap.st.com (beta.dmz-ap.st.com [138.198.100.35]) by mx07-00178001.pphosted.com (PPS) with ESMTPS id 471g8vanv1-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 04 Jun 2025 18:39:21 +0200 (MEST) Received: from euls16034.sgp.st.com (euls16034.sgp.st.com [10.75.44.20]) by beta.dmz-ap.st.com (STMicroelectronics) with ESMTP id B11B840049; Wed, 4 Jun 2025 18:37:36 +0200 (CEST) Received: from Webmail-eu.st.com (shfdag1node3.st.com [10.75.129.71]) by euls16034.sgp.st.com (STMicroelectronics) with ESMTP id 45605B4A8DE; Wed, 4 Jun 2025 18:35:51 +0200 (CEST) Received: from [10.130.77.120] (10.130.77.120) by SHFDAG1NODE3.st.com (10.75.129.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Wed, 4 Jun 2025 18:35:50 +0200 Message-ID: <3c7da784-e58e-4acd-a37f-93020796c0e7@foss.st.com> Date: Wed, 4 Jun 2025 18:35:49 +0200 Precedence: bulk X-Mailing-List: linux-pci@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: Christian Bruel Subject: Re: [PATCH v8 2/9] PCI: stm32: Add PCIe host support for STM32MP25 To: Manivannan Sadhasivam CC: Manivannan Sadhasivam , , , , , , , , , , , , , , , , , , , References: <20250423090119.4003700-1-christian.bruel@foss.st.com> <20250423090119.4003700-3-christian.bruel@foss.st.com> <7df0c1e5-f53b-4a44-920a-c2dfe8842481@foss.st.com> Content-Language: en-US In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: EQNCAS1NODE4.st.com (10.75.129.82) To SHFDAG1NODE3.st.com (10.75.129.71) X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.0.736,FMLib:17.12.80.40 definitions=2025-06-04_03,2025-06-03_02,2025-03-28_01 >>>>>> + >>>>>> + ret = devm_pm_runtime_enable(dev); >>>>>> + if (ret < 0) { >>>>>> + dev_err(dev, "Failed to enable runtime PM %d\n", ret); >>>>>> + return ret; >>>>>> + } >>>>>> + >>>>>> + pm_runtime_get_noresume(dev); >>>>>> + >>>>> >>>>> I know that a lot of the controller drivers do this for no obvious reason. But >>>>> in this case, I believe you want to enable power domain or genpd before >>>>> registering the host bridge. Is that right? >>>> ... Runtime PM was broken in version 6.6 without pm_runtime_get_noresume() On the 6.15 baseline, without this call, pm_genpd_summary reports the correct information: active when a device is plugged, and suspended when not So, I can proceed without pm_runtime_get_noresume(), as you mentioned in your review. I suspect the other platforms might have this call for the same historical reasons. thank you, Christian