From: "Alex G." <mr.nuke.me@gmail.com>
To: Sinan Kaya <okaya@codeaurora.org>, bhelgaas@google.com
Cc: alex_gagniuc@dellteam.com, austin_bolen@dell.com,
shyam_iyer@dell.com, keith.busch@intel.com,
linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] PCI: Check for PCIe downtraining conditions
Date: Thu, 31 May 2018 16:44:16 -0500 [thread overview]
Message-ID: <3e0ddec1-649b-3e97-65e5-073dd9d45a1c@gmail.com> (raw)
In-Reply-To: <e137d5bf-b640-68ef-c07e-d872a9343548@codeaurora.org>
On 05/31/2018 10:30 AM, Sinan Kaya wrote:
> On 5/31/2018 11:05 AM, Alexandru Gagniuc wrote:
>> + if (dev_cur_speed < max_link_speed)
>> + pci_warn(dev, "PCIe downtrain: link speed is %s (%s capable)",
>> + pcie_bus_speed_name(dev_cur_speed),
>> + pcie_bus_speed_name(max_link_speed));
>> +
>
> Also this isn't quite correct. Target link speed is what the device tries to
> train. A device can try to train to much lower speed than the maximum on purpose.
>
> It makes sense to print this if the speed that platform wants via target link
> speed is different from what is actually established though.
After seeing Gen 3 devices that train above the speed in the target link
speed field, I talked to one the spec writers today. There is some
ambiguity with the target link speed field. In PCIe 4.0 they are
clarifying that to state that this field is "permitted to have no effect".
Alex
next prev parent reply other threads:[~2018-05-31 21:44 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-31 15:05 [PATCH] PCI: Check for PCIe downtraining conditions Alexandru Gagniuc
2018-05-31 15:28 ` Sinan Kaya
2018-05-31 15:29 ` Alex_Gagniuc
2018-05-31 15:38 ` Sinan Kaya
2018-05-31 15:46 ` Alex G.
2018-05-31 15:54 ` Sinan Kaya
2018-05-31 16:01 ` Alex G.
2018-05-31 16:13 ` Sinan Kaya
2018-05-31 16:49 ` Alex G.
2018-05-31 16:50 ` Alex G.
2018-05-31 17:11 ` Sinan Kaya
2018-05-31 17:27 ` Alex G.
2018-05-31 21:52 ` Alex G.
2018-05-31 15:30 ` Sinan Kaya
2018-05-31 21:44 ` Alex G. [this message]
2018-06-01 13:30 ` Sinan Kaya
2018-06-02 17:42 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3e0ddec1-649b-3e97-65e5-073dd9d45a1c@gmail.com \
--to=mr.nuke.me@gmail.com \
--cc=alex_gagniuc@dellteam.com \
--cc=austin_bolen@dell.com \
--cc=bhelgaas@google.com \
--cc=keith.busch@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=okaya@codeaurora.org \
--cc=shyam_iyer@dell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).