From: Sergey Shtylyov <s.shtylyov@auroraos.dev>
To: Bjorn Helgaas <bhelgaas@google.com>, <linux-pci@vger.kernel.org>
Cc: "Pali Rohár" <pali@kernel.org>
Subject: Re: [PATCH] PCI: Check parent for NULL in of_pci_bus_release_domain_nr()
Date: Wed, 28 Jan 2026 22:34:06 +0300 [thread overview]
Message-ID: <3e41a321-9110-49ba-afd1-4cafd4649546@auroraos.dev> (raw)
In-Reply-To: <20260127203944.28588-1-s.shtylyov@auroraos.dev>
On 1/27/26 11:39 PM, Sergey Shtylyov wrote:
> of_pci_bus_find_domain_nr() allows its parent parameter to be NULL but
> of_pci_bus_release_domain_nr() (that undoes its effect) doesn't -- that
> means it's going to blow up while calling of_get_pci_domain_nr() if the
> parent parameter indeed happens to be NULL. Add the missing NULL check.
>
> Found by Linux Verification Center (linuxtesting.org) with the Svace static
> analysis tool.
>
> Fixes: c14f7ccc9f5d ("PCI: Assign PCI domain IDs by ida_alloc()")
> Signed-off-by: Sergey Shtylyov <s.shtylyov@auroraos.dev>
> ---
Forgot to add that this patch was done against the for-linus branch of
the pci.git repo...
[...]
MBR, Sergey
next prev parent reply other threads:[~2026-01-28 19:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-27 20:39 [PATCH] PCI: Check parent for NULL in of_pci_bus_release_domain_nr() Sergey Shtylyov
2026-01-28 19:34 ` Sergey Shtylyov [this message]
2026-01-29 18:31 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3e41a321-9110-49ba-afd1-4cafd4649546@auroraos.dev \
--to=s.shtylyov@auroraos.dev \
--cc=bhelgaas@google.com \
--cc=linux-pci@vger.kernel.org \
--cc=pali@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox