From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Return-Path: MIME-Version: 1.0 Date: Wed, 30 May 2018 21:08:42 -0400 From: okaya@codeaurora.org To: Don Brace Subject: Re: [PATCH V3 2/2] scsi: hpsa: drop shutdown callback In-Reply-To: References: <1527542471-10316-1-git-send-email-okaya@codeaurora.org> <1527542471-10316-2-git-send-email-okaya@codeaurora.org> <51bb7b82-c4a1-435c-7668-639db96d76e1@finnie.org> Message-ID: <3ebb873ea4658275e7fa89c01cd8bfe1@codeaurora.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Ryan Finnie , "James E.J. Bottomley" , "open list:HEWLETT-PACKARD SMART ARRAY RAID DRIVER \(hpsa\)" , "Martin K. Petersen" , linux-pci@vger.kernel.org, timur@codeaurora.org, "esc.storagedev" , open list , stable@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+bjorn=helgaas.com@lists.infradead.org List-ID: On 2018-05-30 15:25, Don Brace wrote: >> -----Original Message----- >> From: Ryan Finnie [mailto:ryan@finnie.org] >> Sent: Tuesday, May 29, 2018 8:50 PM >> To: Sinan Kaya ; linux-pci@vger.kernel.org; >> timur@codeaurora.org >> Cc: linux-arm-msm@vger.kernel.org; >> linux-arm-kernel@lists.infradead.org; >> stable@vger.kernel.org; Don Brace ; James >> E.J. >> Bottomley ; Martin K. Petersen >> ; esc.storagedev >> ; open list:HEWLETT-PACKARD SMART ARRAY >> RAID DRIVER (hpsa) ; open list > kernel@vger.kernel.org> >> Subject: Re: [PATCH V3 2/2] scsi: hpsa: drop shutdown callback >> >> EXTERNAL EMAIL >> >> >> On 05/28/2018 02:21 PM, Sinan Kaya wrote: >> > 'Commit cc27b735ad3a ("PCI/portdrv: Turn off PCIe services during >> > shutdown")' has been added to kernel to shutdown pending PCIe port >> > service interrupts during reboot so that a newly started kexec kernel >> > wouldn't observe pending interrupts. >> > >> > pcie_port_device_remove() is disabling the root port and switches by >> > calling pci_disable_device() after all PCIe service drivers are shutdown. >> > >> > This has been found to cause crashes on HP DL360 Gen9 machines during >> > reboot due to hpsa driver not clearing the bus master bit during the >> > shutdown procedure by calling pci_disable_device(). >> > >> > Drop the shutdown API and do an orderly clean up by using the remove. >> > >> > Signed-off-by: Sinan Kaya >> > Link: https://bugzilla.kernel.org/show_bug.cgi?id=199779 >> > Fixes: cc27b735ad3a ("PCI/portdrv: Turn off PCIe services during shutdown") >> > Cc: stable@vger.kernel.org >> > Reported-by: Ryan Finnie >> >> Tested successfully on DL360 Gen9 and DL380 Gen9. >> >> Tested-by: Ryan Finnie > > The shutdown path issues a cache flush to the controller. > Without this flush, you will see "Dirty Cache" messages at POST. > It is best to keep the shutdown path. > I have seen that shutdown() is also called from remove(). remove() is supposed to do a safe cleanup too. If it is leaving the hw in inconsistent state even though it is c lling shutdown , it is yet another bug. > Thanks, > Don Brace > ESC - Smart Storage > Microsemi Corporation _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel