From: Sinan Kaya <okaya@codeaurora.org>
To: Dennis Dalessandro <dennis.dalessandro@intel.com>,
bhelgaas@google.com, linux-pci@vger.kernel.org
Subject: Re: bug in pci_try_reset_bus
Date: Tue, 28 Aug 2018 09:25:40 -0400 [thread overview]
Message-ID: <401a24b3-c7bb-03ee-8753-0c94d8aee79c@codeaurora.org> (raw)
In-Reply-To: <980dc79b-a1b7-08ab-294f-1cb318d996fe@intel.com>
On 8/27/2018 4:48 PM, Dennis Dalessandro wrote:
>> Possible solutions are:
>> 1. introduce a locked reset API > 2. skip lock during probe
>> 3. bring back raw reset API even though it is undesirable.
>
> I think the first option is the cleanest. I can put together a patch and
> post it soon.
I was thinking about this. These locked API are getting out of control. It could
be a simpler solution to change the mutex type of device_lock such that it can
be locked twice. I think I have seen some examples of how to do this in the
NVMe driver.
prev parent reply other threads:[~2018-08-28 17:17 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <3d3d78fb-f1f2-ec4f-38f9-0b0d14564f53@intel.com>
[not found] ` <323b3bbe-d255-8a5d-2a9c-d64e1f86cb64@codeaurora.org>
[not found] ` <bd7dbd5a-eebc-9142-f9a2-3b5ff8de9b8b@intel.com>
[not found] ` <d437400c-7eed-19d3-9cf2-b8a42217136b@codeaurora.org>
[not found] ` <2f0fb394-f1c9-d782-ffec-dac04b1ac0a9@intel.com>
2018-08-27 19:08 ` bug in pci_try_reset_bus Sinan Kaya
2018-08-27 19:52 ` Dennis Dalessandro
2018-08-27 20:18 ` Sinan Kaya
2018-08-27 20:48 ` Dennis Dalessandro
2018-08-28 13:25 ` Sinan Kaya [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=401a24b3-c7bb-03ee-8753-0c94d8aee79c@codeaurora.org \
--to=okaya@codeaurora.org \
--cc=bhelgaas@google.com \
--cc=dennis.dalessandro@intel.com \
--cc=linux-pci@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).