From: Arnd Bergmann <arnd@arndb.de>
To: Yoshinori Sato <ysato@users.sourceforge.jp>
Cc: devicetree@vger.kernel.org, linux-pci@vger.kernel.org,
linux-sh@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 12/22] sh: Add PCI host bridge driver for SH7751
Date: Wed, 29 Jun 2016 16:57:50 +0200 [thread overview]
Message-ID: <4273068.i3RgB4Ufiy@wuerfel> (raw)
In-Reply-To: <1467207667-15768-13-git-send-email-ysato@users.sourceforge.jp>
On Wednesday, June 29, 2016 10:40:57 PM CEST Yoshinori Sato wrote:
> + interrupt-map = <0x0000 0 1 &cpldintc 0 0>,
> + 0x0800 0 1 &cpldintc 1 0>,
> + 0x1000 0 1 &cpldintc 2 0>,
> + 0x1800 0 1 &cpldintc 3 0>,
> + 0x1800 0 2 &cpldintc 0 0>;
I just noticed the typo: you have more closing '>' than opening '<'
here, so this is not valid syntax.
> +
> +static __refdata struct platform_driver sh7751_pci_driver = {
> + .driver = {
> + .name = "sh7751-pci",
> + .of_match_table = sh7751_pci_of_match,
> + },
> + .probe = sh7751_pci_probe,
> +};
> +builtin_platform_driver(sh7751_pci_driver);
I think you need to add '.suppress_bind_attrs = true' to prevent
the device to be unbound and rebound through sysfs, otherwise
the __init annotation on the probe function is wrong.
Everything else looks fine to me now.
Arnd
next prev parent reply other threads:[~2016-06-29 14:55 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1467207667-15768-1-git-send-email-ysato@users.sourceforge.jp>
2016-06-29 13:40 ` [PATCH v4 12/22] sh: Add PCI host bridge driver for SH7751 Yoshinori Sato
2016-06-29 14:57 ` Arnd Bergmann [this message]
2016-06-30 14:52 ` Yoshinori Sato
2016-07-01 1:43 ` Rob Herring
2016-06-29 13:41 ` [PATCH v4 16/22] pci: pci_config_window move to linux/pci.h Yoshinori Sato
2016-06-29 13:41 ` [PATCH v4 17/22] pci: PCI_HOST_GENERIC enable for SH Yoshinori Sato
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4273068.i3RgB4Ufiy@wuerfel \
--to=arnd@arndb.de \
--cc=devicetree@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=ysato@users.sourceforge.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox