From: "Desnes Augusto Nunes do Rosário" <desnesn@linux.vnet.ibm.com>
To: Bjorn Helgaas <helgaas@kernel.org>
Cc: linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org,
linuxppc-dev@lists.ozlabs.org, bhelgaas@google.com,
benh@kernel.crashing.org, paulus@samba.org, mpe@ellerman.id.au,
ruscur@russell.cc, aik@ozlabs.ru, david@gibson.dropbear.id.au,
fbarrat@linux.vnet.ibm.com, brking@linux.vnet.ibm.com
Subject: Re: [PATCH 1/2, pci] pci: Addition of PCI_DEV_FLAGS_QUIET_PCI_REALIGN attribute to the PCI subsystem
Date: Wed, 14 Mar 2018 18:12:23 -0300 [thread overview]
Message-ID: <442e2ae9-9423-8bf3-a7c1-a35381781145@linux.vnet.ibm.com> (raw)
In-Reply-To: <20180314185508.GE179719@bhelgaas-glaptop.roam.corp.google.com>
On 03/14/2018 03:55 PM, Bjorn Helgaas wrote:
>>> As far as I'm concerned, we can just remove these messages completely.
>>> I don't think there's any real value there.
>>
>> After I found out that this was happening to all PCI devices on powerpc due
>> to the __weak
>> pcibios_default_alignment() interface (necessary for VFIO passthrough and
>> performance), I confess that this was my first approach to this matter;
>> however I couldn't vouch the need of these messages on other architectures.
>>
>> If there are no further concerns, I definitely prefer sending a second
>> version of this patch only eliminating these messages and attesting the
>> reason why.
>>
>> Thank you very much for your review Bjorn,
>
> No problem, welcome to PCI, and I hope we see more of your work!
Bjorn,
Awesome! A second version of this fix has been sent with a new title:
"[PATCH, pci, v2] pci: Delete PCI disabling informational messages"
Thanks for the review and warm welcome!
--
Desnes A. Nunes do Rosário
--------------------------
next prev parent reply other threads:[~2018-03-14 21:12 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-14 16:34 [PATCH 0/2] Silent PCI realignment messages during boot Desnes A. Nunes do Rosario
2018-03-14 16:34 ` [PATCH 1/2, pci] pci: Addition of PCI_DEV_FLAGS_QUIET_PCI_REALIGN attribute to the PCI subsystem Desnes A. Nunes do Rosario
2018-03-14 17:41 ` Andy Shevchenko
2018-03-14 17:42 ` Andy Shevchenko
2018-03-14 18:09 ` Desnes Augusto Nunes do Rosário
2018-03-14 18:06 ` Bjorn Helgaas
2018-03-14 18:22 ` Desnes Augusto Nunes do Rosário
2018-03-14 18:55 ` Bjorn Helgaas
2018-03-14 21:12 ` Desnes Augusto Nunes do Rosário [this message]
2018-03-14 16:34 ` [PATCH 2/2, powerpc/powernv] powerpc/powernv: Tweak PCI_DEV_FLAGS_QUIET_PCI_REALIGN on/off during boot Desnes A. Nunes do Rosario
2018-03-16 8:41 ` kbuild test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=442e2ae9-9423-8bf3-a7c1-a35381781145@linux.vnet.ibm.com \
--to=desnesn@linux.vnet.ibm.com \
--cc=aik@ozlabs.ru \
--cc=benh@kernel.crashing.org \
--cc=bhelgaas@google.com \
--cc=brking@linux.vnet.ibm.com \
--cc=david@gibson.dropbear.id.au \
--cc=fbarrat@linux.vnet.ibm.com \
--cc=helgaas@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=paulus@samba.org \
--cc=ruscur@russell.cc \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).