From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 33BB2C4332F for ; Mon, 6 Nov 2023 12:33:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231549AbjKFMd5 (ORCPT ); Mon, 6 Nov 2023 07:33:57 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55002 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231493AbjKFMd4 (ORCPT ); Mon, 6 Nov 2023 07:33:56 -0500 Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.20]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B28DE97; Mon, 6 Nov 2023 04:33:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1699274033; x=1730810033; h=date:from:to:cc:subject:in-reply-to:message-id: references:mime-version; bh=lly8ppgmxcDDLOmDBL4aU0UCetKvXa6D6CEONx55ShM=; b=fl1HAM8RLmfBfFwSXhfJ2lfviepCCwgP/bGCGYfuPGdd4mOtgtsC9BB+ flZFOuZPzuBxjisjuH9GddRb4DWZz2BGCf2Y7EX31vSLvxoYSbKV9z+mw 1+aXI8v6inGgtq56I122ebpKVaRgfuIM8rdQpJwiCw0x9EFggcum3DOLo 14VtFWl8dkrsRNlmUijI0FGn7mllUlv5lectJmS4BcsZ540qKSZtPGeQA RjcnjSiYiSPhfEIuLOKm82SIKQMnWceXVhdjJcVk8ynhszfaThMMmhEHO pNn1wmSFw31age3VFkeY6mLw1HX7mbhR1lgspmJ0EmJhiHT3pvrBjSXgk g==; X-IronPort-AV: E=McAfee;i="6600,9927,10885"; a="379657177" X-IronPort-AV: E=Sophos;i="6.03,281,1694761200"; d="scan'208";a="379657177" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Nov 2023 04:33:53 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10885"; a="765938147" X-IronPort-AV: E=Sophos;i="6.03,281,1694761200"; d="scan'208";a="765938147" Received: from rmstoi-mobl.ger.corp.intel.com ([10.251.216.76]) by fmsmga007-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Nov 2023 04:33:43 -0800 Date: Mon, 6 Nov 2023 14:33:40 +0200 (EET) From: =?ISO-8859-15?Q?Ilpo_J=E4rvinen?= To: Mario Limonciello cc: Karol Herbst , Lyude Paul , Alex Deucher , =?ISO-8859-15?Q?Christian_K=F6nig?= , Bjorn Helgaas , Hans de Goede , Mika Westerberg , Lukas Wunner , Danilo Krummrich , David Airlie , Daniel Vetter , Xinhui Pan , "Rafael J . Wysocki" , Mark Gross , Andreas Noever , Michael Jamet , Yehezkel Bernat , =?ISO-8859-15?Q?Pali_Roh=E1r?= , =?ISO-8859-15?Q?Marek_Beh=FAn?= , "Maciej W . Rozycki" , Manivannan Sadhasivam , "open list:DRM DRIVER FOR NVIDIA GEFORCE/QUADRO GPUS" , "open list:DRM DRIVER FOR NVIDIA GEFORCE/QUADRO GPUS" , open list , "open list:RADEON and AMDGPU DRM DRIVERS" , "open list:PCI SUBSYSTEM" , "open list:ACPI" , "open list:X86 PLATFORM DRIVERS" , "open list:THUNDERBOLT DRIVER" Subject: Re: [PATCH v2 3/9] PCI: Drop pci_is_thunderbolt_attached() In-Reply-To: <20231103190758.82911-4-mario.limonciello@amd.com> Message-ID: <4747b7b8-ea48-4117-f746-a18dae97bc2@linux.intel.com> References: <20231103190758.82911-1-mario.limonciello@amd.com> <20231103190758.82911-4-mario.limonciello@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org On Fri, 3 Nov 2023, Mario Limonciello wrote: > All callers have switched to dev_is_removable() for detecting > hotpluggable PCIe devices. > > Signed-off-by: Mario Limonciello > --- > include/linux/pci.h | 22 ---------------------- > 1 file changed, 22 deletions(-) > > diff --git a/include/linux/pci.h b/include/linux/pci.h > index b56417276042..530b0a360514 100644 > --- a/include/linux/pci.h > +++ b/include/linux/pci.h > @@ -2616,28 +2616,6 @@ static inline bool pci_ari_enabled(struct pci_bus *bus) > return bus->self && bus->self->ari_enabled; > } > > -/** > - * pci_is_thunderbolt_attached - whether device is on a Thunderbolt daisy chain > - * @pdev: PCI device to check > - * > - * Walk upwards from @pdev and check for each encountered bridge if it's part > - * of a Thunderbolt controller. Reaching the host bridge means @pdev is not > - * Thunderbolt-attached. (But rather soldered to the mainboard usually.) > - */ > -static inline bool pci_is_thunderbolt_attached(struct pci_dev *pdev) > -{ > - struct pci_dev *parent = pdev; > - > - if (pdev->is_thunderbolt) > - return true; > - > - while ((parent = pci_upstream_bridge(parent))) > - if (parent->is_thunderbolt) > - return true; > - > - return false; > -} > - > #if defined(CONFIG_PCIEPORTBUS) || defined(CONFIG_EEH) > void pci_uevent_ers(struct pci_dev *pdev, enum pci_ers_result err_type); > #endif > I don't think all callers have been removed. Ah, lkp has caught the same problem. -- i.