From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
To: Varadarajan Narayanan <quic_varada@quicinc.com>,
bhelgaas@google.com, lpieralisi@kernel.org, kw@linux.com,
manivannan.sadhasivam@linaro.org, robh@kernel.org,
krzk+dt@kernel.org, conor+dt@kernel.org, andersson@kernel.org,
konradybcio@kernel.org, linux-arm-msm@vger.kernel.org,
linux-pci@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Cc: Praveenkumar I <quic_ipkumar@quicinc.com>
Subject: Re: [PATCH v14 3/4] arm64: dts: qcom: ipq5332: Add PCIe related nodes
Date: Fri, 11 Apr 2025 13:22:39 +0200 [thread overview]
Message-ID: <48361e2a-89b2-4474-97aa-557fbbbdf601@oss.qualcomm.com> (raw)
In-Reply-To: <20250317100029.881286-4-quic_varada@quicinc.com>
On 3/17/25 11:00 AM, Varadarajan Narayanan wrote:
> From: Praveenkumar I <quic_ipkumar@quicinc.com>
>
> Add phy and controller nodes for pcie0_x1 and pcie1_x2.
>
> Signed-off-by: Praveenkumar I <quic_ipkumar@quicinc.com>
> Signed-off-by: Varadarajan Narayanan <quic_varada@quicinc.com>
> ---
[...]
I think you're reaching out of the BAR register space by an order of magnitude,
on both hosts
IIUC it's only 32 MiB for both
the register addresses/sizes look good
I'm not super glad that we decided to move forward with not putting PARF first,
as the other registers are in the BAR region, but bindings are bindings and
bindings are ABI..
Konrad
next prev parent reply other threads:[~2025-04-11 11:22 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-17 10:00 [PATCH v14 0/4] Add PCIe support for Qualcomm IPQ5332 Varadarajan Narayanan
2025-03-17 10:00 ` [PATCH v14 1/4] dt-bindings: PCI: qcom: Add MHI registers for IPQ9574 Varadarajan Narayanan
2025-03-17 13:23 ` Krzysztof Kozlowski
2025-03-17 10:00 ` [PATCH v14 2/4] arm64: dts: qcom: ipq9574: Add MHI to pcie nodes Varadarajan Narayanan
2025-04-11 11:08 ` Konrad Dybcio
2025-03-17 10:00 ` [PATCH v14 3/4] arm64: dts: qcom: ipq5332: Add PCIe related nodes Varadarajan Narayanan
2025-04-11 11:22 ` Konrad Dybcio [this message]
2025-04-15 9:50 ` Varadarajan Narayanan
2025-04-15 10:56 ` Konrad Dybcio
2025-03-17 10:00 ` [PATCH v14 4/4] arm64: dts: qcom: ipq5332-rdp441: Enable PCIe phys and controllers Varadarajan Narayanan
2025-05-20 2:14 ` (subset) [PATCH v14 0/4] Add PCIe support for Qualcomm IPQ5332 Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48361e2a-89b2-4474-97aa-557fbbbdf601@oss.qualcomm.com \
--to=konrad.dybcio@oss.qualcomm.com \
--cc=andersson@kernel.org \
--cc=bhelgaas@google.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=kw@linux.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lpieralisi@kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=quic_ipkumar@quicinc.com \
--cc=quic_varada@quicinc.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox