From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mout.kundenserver.de ([212.227.126.187]:61029 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755316AbaIDVMR (ORCPT ); Thu, 4 Sep 2014 17:12:17 -0400 From: Arnd Bergmann To: linux-arm-kernel@lists.infradead.org Cc: Fabio Estevam , Minghuan Lian , Scott Wood , "linux-pci@vger.kernel.org" , Hu Mingkai-B21284 , Zang Roy-R61911 Subject: Re: [PATCH 2/2] PCI: Layerscape: Add Layerscape PCIe driver Date: Thu, 04 Sep 2014 23:12:09 +0200 Message-ID: <4843064.4PPheKAzXq@wuerfel> In-Reply-To: References: <1409856338-1730-1-git-send-email-Minghuan.Lian@freescale.com> <1409856338-1730-2-git-send-email-Minghuan.Lian@freescale.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Sender: linux-pci-owner@vger.kernel.org List-ID: On Thursday 04 September 2014 17:21:48 Fabio Estevam wrote: > On Thu, Sep 4, 2014 at 3:45 PM, Minghuan Lian > wrote: > > Add support for Freescale Layerscape PCIe controller. This driver > > re-uses the designware core code. > > It seems that this is the same IP as on mx6, right? > > Is it possible to adapt drivers/pci/host/pci-imx6.c to work on Layerscape? For all I can tell, the common parts are already shared in pcie-designware.c, while the new file contains only those parts that are specific to layerscape and different from imx. If there are parts in there that are the same between layerscape and imx, the implementation should also be moved to a shared file. Arnd