Re: [RFC PATCH 1/1]PCI: defer enablement of SRIOV BARS

[Michael Wang <wangyun@linux.vnet.ibm.com>]

On 11/14/2011 12:33 PM, Ram Pai wrote:
> On Fri, Nov 11, 2011 at 10:01:43AM -0800, Jesse Barnes wrote:
>> On Sun, 6 Nov 2011 10:33:10 +0800
>> Ram Pai<linuxram@us.ibm.com>  wrote:
>>
>>>    All the PCI BARs of a device are enabled when the device is enabled using
>>>    pci_enable_device().  This unnecessarily enables SRIOV BARs of the device.
>>>
>>>    On some platforms, which do not support SRIOV as yet, the pci_enable_device()
>>>    fails to enable the device if its SRIOV BARs are not allocated resources
>>>    correctly.
>>>
>>>    The following patch fixes the above problem. The SRIOV BARs are now enabled
>>>    when IOV capability of the device is enabled in sriov_enable().
>>>
>>>    NOTE: Note, there is subtle change in the pci_enable_device() API.
>>>    Any driver that depends on SRIOV BARS to be enabled in pci_enable_device()
>>>    can fail.
>>>
>>>    The patch has been touch tested on power and x86 platform.
>>>
>>>    Signed-off-by: Ram Pai<linuxram@us.ibm.com>
>>> ---
>> I think this is a good direction, but I'd like to get a tested-by or
>> two from people using SR-IOV...
> I have people within IBM who have tested this patch successfully.
> Michael Wang/Nish: Can you provide us a tested-by for this patch?
Hi

I have tested both patches with Fedora16 KVM kernel on a power machine.
My original issue is that the be2net module failed to be loaded, and the 
patch
fixes it.
After applied the patch, the be2net module can be loaded normally and new
network interfaces appeared.

Tested-by: Michael Wang <wangyun@linux.vnet.ibm.com>

Thanks,
Michael Wang
> Prarit: Can you give this patch and the other patch a try?
> the other patch is: [RFC PATCH 1/1] PCI:delay configuration of SRIOV capability
>
> RP