* [PATCH] PCI / Hotplug: Fix the ordering of operations in pcied_cleanup()
@ 2011-11-22 22:05 Rafael J. Wysocki
2011-11-23 4:10 ` Kenji Kaneshige
0 siblings, 1 reply; 2+ messages in thread
From: Rafael J. Wysocki @ 2011-11-22 22:05 UTC (permalink / raw)
To: Jesse Barnes; +Cc: LKML, Linux PM list, linux-pci, Oliver Neukum
From: Rafael J. Wysocki <rjw@sisk.pl>
Make pcied_cleanup() unregister the port service before
destroying workqueues that are flushed during the port service
unregistration.
Reported-by: Oliver Neukum <oneukum@suse.de>
Signed-off-by: Rafael J. Wysocki <rjw@sisk.pl>
---
drivers/pci/hotplug/pciehp_core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Index: linux/drivers/pci/hotplug/pciehp_core.c
===================================================================
--- linux.orig/drivers/pci/hotplug/pciehp_core.c
+++ linux/drivers/pci/hotplug/pciehp_core.c
@@ -366,9 +366,9 @@ static int __init pcied_init(void)
static void __exit pcied_cleanup(void)
{
dbg("unload_pciehpd()\n");
+ pcie_port_service_unregister(&hpdriver_portdrv);
destroy_workqueue(pciehp_ordered_wq);
destroy_workqueue(pciehp_wq);
- pcie_port_service_unregister(&hpdriver_portdrv);
info(DRIVER_DESC " version: " DRIVER_VERSION " unloaded\n");
}
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] PCI / Hotplug: Fix the ordering of operations in pcied_cleanup()
2011-11-22 22:05 [PATCH] PCI / Hotplug: Fix the ordering of operations in pcied_cleanup() Rafael J. Wysocki
@ 2011-11-23 4:10 ` Kenji Kaneshige
0 siblings, 0 replies; 2+ messages in thread
From: Kenji Kaneshige @ 2011-11-23 4:10 UTC (permalink / raw)
To: Rafael J. Wysocki
Cc: Jesse Barnes, LKML, Linux PM list, linux-pci, Oliver Neukum
I've sent the patch to fix the problem a few weeks ago, and it is in
Jesse's -next tree.
Regards,
Kenji Kaneshige
(2011/11/23 7:05), Rafael J. Wysocki wrote:
> From: Rafael J. Wysocki<rjw@sisk.pl>
>
> Make pcied_cleanup() unregister the port service before
> destroying workqueues that are flushed during the port service
> unregistration.
>
> Reported-by: Oliver Neukum<oneukum@suse.de>
> Signed-off-by: Rafael J. Wysocki<rjw@sisk.pl>
> ---
> drivers/pci/hotplug/pciehp_core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> Index: linux/drivers/pci/hotplug/pciehp_core.c
> ===================================================================
> --- linux.orig/drivers/pci/hotplug/pciehp_core.c
> +++ linux/drivers/pci/hotplug/pciehp_core.c
> @@ -366,9 +366,9 @@ static int __init pcied_init(void)
> static void __exit pcied_cleanup(void)
> {
> dbg("unload_pciehpd()\n");
> + pcie_port_service_unregister(&hpdriver_portdrv);
> destroy_workqueue(pciehp_ordered_wq);
> destroy_workqueue(pciehp_wq);
> - pcie_port_service_unregister(&hpdriver_portdrv);
> info(DRIVER_DESC " version: " DRIVER_VERSION " unloaded\n");
> }
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-pci" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-11-23 4:11 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-11-22 22:05 [PATCH] PCI / Hotplug: Fix the ordering of operations in pcied_cleanup() Rafael J. Wysocki
2011-11-23 4:10 ` Kenji Kaneshige
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).