From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from oproxy5-pub.bluehost.com ([67.222.38.55]:35406 "HELO oproxy5-pub.bluehost.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1760222Ab1LPRmF (ORCPT ); Fri, 16 Dec 2011 12:42:05 -0500 Message-ID: <4EEB9105.3030100@xenotime.net> Date: Fri, 16 Dec 2011 10:42:13 -0800 From: Randy Dunlap MIME-Version: 1.0 To: Bjorn Helgaas CC: Jesse Barnes , Stephen Rothwell , linux-next@vger.kernel.org, LKML , linux-pci@vger.kernel.org Subject: Re: linux-next: Tree for Dec 9 (ibmphp) References: <20111209163247.1de15dcb5b735ca5e1ad030b@canb.auug.org.au> <4EE637F3.7070606@xenotime.net> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-pci-owner@vger.kernel.org List-ID: On 12/13/2011 04:41 PM, Bjorn Helgaas wrote: > On Mon, Dec 12, 2011 at 10:20 AM, Randy Dunlap wrote: >> On 12/09/2011 10:51 AM, Randy Dunlap wrote: >>> >>> On Thu, December 8, 2011 9:32 pm, Stephen Rothwell wrote: >>>> Hi all, >>>> >>>> Changes since 20111208: >>> >>> (This build error was first seen in 20111208.) >>> >>> >>> ERROR: "pci_scan_bus" [drivers/pci/hotplug/ibmphp.ko] undefined! >>> >>> Full randconfig file is attached. >> >> >> Same for 20111212. > > I changed pci_scan_bus() from an inline function (visible to modules) > to a normal function (by default, not visible to modules), which broke > the ibmphp.ko build. > > The updated patch is attached, as well as the incremental change (just > adding "EXPORT_SYMBOL(pci_scan_bus);". Acked-by: Randy Dunlap Thanks. (although those git sha hashes in the filenames did confuse 'patch'; maybe I need a newer version of patch) > (Also available at git://github.com/bjorn-helgaas/linux.git on the "pci-scan-v6" > branch as bef4a9eefaa69dd9bc998e29d619127d1653683d) > > Bjorn -- ~Randy *** Remember to use Documentation/SubmitChecklist when testing your code ***