linux-pci.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Christian Inci <chris.pcguy.inci@gmail.com>
To: linux-pci@vger.kernel.org
Subject: [PATCH] fix for a bash issue regarding a variable in update-pciids
Date: Fri, 23 Dec 2011 01:33:40 +0100	[thread overview]
Message-ID: <4EF3CC64.40705@gmail.com> (raw)

>From f9d728aa77fc53189f750286b327361a707f0533 Mon Sep 17 00:00:00 2001
From: Christian Inci <chris.pcguy.inci@gmail.com>
Date: Fri, 23 Dec 2011 01:13:16 +0100
Subject: [PATCH] fix for a bash issue regarding a variable in update-pciids
 At least some bash versions can and will complain about an
 empty PCI_COMPRESSED_IDS variable, when it get used in the
 'if'-statement.

e.g. with a message like:
  "/usr/sbin/update-pciids: line 18: [: : integer expression expected"

Signed-off-by: Christian Inci <chris.pcguy.inci@gmail.com>
---
 update-pciids.sh |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/update-pciids.sh b/update-pciids.sh
index 5e77109..708e3b3 100755
--- a/update-pciids.sh
+++ b/update-pciids.sh
@@ -5,7 +5,7 @@
 set -e
 SRC="http://pciids.sourceforge.net/v2.2/pci.ids"
 DEST=pci.ids
-PCI_COMPRESSED_IDS=
+PCI_COMPRESSED_IDS=0
 GREP=grep
 
 # if pci.ids is read-only (because the filesystem is read-only),
-- 
1.7.7.4

                 reply	other threads:[~2011-12-23  0:33 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4EF3CC64.40705@gmail.com \
    --to=chris.pcguy.inci@gmail.com \
    --cc=linux-pci@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).