linux-pci.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH]: fix for a bash issue regarding a variable in update-pciids (try 2)
@ 2011-12-23 17:13 Christian Inci
  0 siblings, 0 replies; only message in thread
From: Christian Inci @ 2011-12-23 17:13 UTC (permalink / raw)
  To: linux-pci

>From ced082632d496645736f245b6a6482bdbf267579 Mon Sep 17 00:00:00 2001
From: Christian Inci <chris.pcguy.inci@gmail.com>
Date: Fri, 23 Dec 2011 17:24:56 +0100
Subject: [PATCH]: fix for a bash issue regarding a variable ... (try 2)
 in update-pciids At least some bash versions can and
 will complain about an  empty PCI_COMPRESSED_IDS variable,
 when it get used in the  'if'-statement.

Try 2: change the comparison operand instead of the value.
 Many thanks to Martin Mares <mj@ucw.cz> for the hint.

Signed-off-by: Christian Inci <chris.pcguy.inci@gmail.com>
---
 update-pciids.sh |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/update-pciids.sh b/update-pciids.sh
index 5e77109..51397f1 100755
--- a/update-pciids.sh
+++ b/update-pciids.sh
@@ -15,7 +15,7 @@ if ! touch ${DEST} >/dev/null 2>&1 ; then
 	exit 1
 fi
 
-if [ "$PCI_COMPRESSED_IDS" -eq 1 ] ; then
+if [ "$PCI_COMPRESSED_IDS" == 1 ] ; then
 	DECOMP="cat"
 	SRC="$SRC.gz"
 	GREP=zgrep
-- 
1.7.7.4

^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2011-12-23 17:13 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-12-23 17:13 [PATCH]: fix for a bash issue regarding a variable in update-pciids (try 2) Christian Inci

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).