From: Randy Dunlap <rdunlap@xenotime.net>
To: Bjorn Helgaas <bhelgaas@google.com>
Cc: Jesse Barnes <jbarnes@virtuousgeek.org>,
Stephen Rothwell <sfr@canb.auug.org.au>,
linux-next@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
x86 maintainers <x86@kernel.org>,
linux-pci@vger.kernel.org, Yinghai Lu <yinghai@kernel.org>
Subject: Re: linux-next: Tree for Jan 9 (arch/x86/pci/amd_bus.c)
Date: Tue, 10 Jan 2012 12:57:54 -0800 [thread overview]
Message-ID: <4F0CA652.5040103@xenotime.net> (raw)
In-Reply-To: <CAErSpo4+remnOA6gJXOz_54CsbbcOq_Yj=ua9gV_bq5dZ64ABA@mail.gmail.com>
On 01/09/2012 02:40 PM, Bjorn Helgaas wrote:
> On Mon, Jan 9, 2012 at 2:05 PM, Randy Dunlap <rdunlap@xenotime.net> wrote:
>> on several i386 builds:
>>
>> amd_bus.c:(.init.text+0x134b): undefined reference to `amd_get_mmconfig_range'
>
> This is my fault. I moved some code from amd_bus.c to amd_nb.c, and builds with
>
> CONFIG_PCI=y
> # CONFIG_AMD_NB not set
>
> now fail. The attached patch should fix it. I'll repost the series
> ("x86/PCI: amd: factor out MMCONFIG discovery") with the fix.
>
> Yinghai, it looks to me like there's no reason to build amd_bus.o
> unless we have CONFIG_AMD_NB=y, but speak up if I'm wrong :)
Seems to work for me. Thanks.
--
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
prev parent reply other threads:[~2012-01-10 19:59 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20120109170457.4465dfc66a0eace4a2230fef@canb.auug.org.au>
[not found] ` <4F0B569B.6050004@xenotime.net>
2012-01-09 22:40 ` linux-next: Tree for Jan 9 (arch/x86/pci/amd_bus.c) Bjorn Helgaas
2012-01-10 20:57 ` Randy Dunlap [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F0CA652.5040103@xenotime.net \
--to=rdunlap@xenotime.net \
--cc=bhelgaas@google.com \
--cc=jbarnes@virtuousgeek.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
--cc=x86@kernel.org \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).