linux-pci.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Pratyush Anand <pratyush.anand@st.com>
To: Tejun Heo <tj@kernel.org>
Cc: "Pedanekar, Hemant" <hemantp@ti.com>,
	"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
	Viresh KUMAR <viresh.kumar@st.com>,
	Shiraz HASHIM <shiraz.hashim@st.com>,
	Armando VISCONTI <armando.visconti@st.com>,
	Vipin KUMAR <vipin.kumar@st.com>,
	Deepak SIKRI <deepak.sikri@st.com>,
	Rajeev KUMAR <rajeev-dlh.kumar@st.com>,
	Vipul Kumar SAMAR <vipulkumar.samar@st.com>,
	Amit VIRDI <Amit.VIRDI@st.com>,
	Bhupesh SHARMA <bhupesh.sharma@st.com>
Subject: Re: [PATCH] PCIE: pcie_set_readrq must not be allowed by PCIE EP driver
Date: Fri, 24 Feb 2012 09:27:50 +0530	[thread overview]
Message-ID: <4F470ABE.2010206@st.com> (raw)
In-Reply-To: <20120223174228.GF22536@google.com>

On 2/23/2012 11:12 PM, Tejun Heo wrote:
> Hello,
>
> On Thu, Feb 23, 2012 at 03:31:29PM +0530, Pratyush Anand wrote:
>> Its a long pending patch.
>> Any decision on this patch.
>
> Hmmm.... I really don't know what to do.  IIRC it was something lifted
> from the proprietary sil driver and they probably added that to work
> around performance oddities under certain configurations and I'm a bit
> worried about changing it after all this time.  Is there any way to
> make this conditional somehow?

I see that there is a patch in the latest kernel.

commit a1c473aa11e61bc871be16279c9bf976acf22504
Author: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Date:   Fri Oct 14 14:56:15 2011 -0500

     pci: Clamp pcie_set_readrq() when using "performance" settings

I think, this will resolve the issue.
We are moving to the new kernel. Will check it there.

Regards
Pratyush

>
> Thanks.
>


  reply	other threads:[~2012-02-24  3:58 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1297937650-2558-1-git-send-email-pratyush.anand@st.com>
     [not found] ` <2A3DCF3DA181AD40BDE86A3150B27B6B0373799132@dbde02.ent.ti.com>
     [not found]   ` <2A3DCF3DA181AD40BDE86A3150B27B6B03737991EA@dbde02.ent.ti.com>
     [not found]     ` <4D78D6E3.50004@st.com>
     [not found]       ` <2A3DCF3DA181AD40BDE86A3150B27B6B03743048FE@dbde02.ent.ti.com>
     [not found]         ` <4D806132.1090704@st.com>
2012-02-23 10:01           ` [PATCH] PCIE: pcie_set_readrq must not be allowed by PCIE EP driver Pratyush Anand
2012-02-23 17:42             ` Tejun Heo
2012-02-24  3:57               ` Pratyush Anand [this message]
2012-02-24  5:38                 ` Pedanekar, Hemant
2012-02-24  6:09                   ` Pratyush Anand

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F470ABE.2010206@st.com \
    --to=pratyush.anand@st.com \
    --cc=Amit.VIRDI@st.com \
    --cc=armando.visconti@st.com \
    --cc=bhupesh.sharma@st.com \
    --cc=deepak.sikri@st.com \
    --cc=hemantp@ti.com \
    --cc=linux-pci@vger.kernel.org \
    --cc=rajeev-dlh.kumar@st.com \
    --cc=shiraz.hashim@st.com \
    --cc=tj@kernel.org \
    --cc=vipin.kumar@st.com \
    --cc=vipulkumar.samar@st.com \
    --cc=viresh.kumar@st.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).