From: Jiang Liu <jiang.liu@huawei.com>
To: Yinghai Lu <yinghai@kernel.org>
Cc: Jiang Liu <liuj97@gmail.com>,
Jesse Barnes <jbarnes@virtuousgeek.org>,
Bjorn Helgaas <bhelgaas@google.com>,
Ashok Raj <ashok.raj@intel.com>,
Suresh Siddha <suresh.b.siddha@intel.com>,
Youquan Song <youquan.song@intel.com>,
linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
chenkeping@huawei.com
Subject: Re: [PATCH 2/5] Correctly clean up pci root buses in function pci_remove_bus()
Date: Tue, 13 Mar 2012 15:23:30 +0800 [thread overview]
Message-ID: <4F5EF5F2.2000507@huawei.com> (raw)
In-Reply-To: <CAE9FiQVRMBHN+QbFpVv4j2xPfco2X0bt9OzzcSE-BrrDY4Oqgg@mail.gmail.com>
Hi Yinghai,
Good points! It's safe with current implementation because
all root bus hotplug operations are under protection of
pci_remove_rescan_mutex.
On 2012-3-13 14:24, Yinghai Lu wrote:
> On Sun, Mar 11, 2012 at 10:48 AM, Jiang Liu<liuj97@gmail.com> wrote:
>> The function pci_create_root_bus() allocates the pci bus structure,
>> registers the bus device and creates the legacy files for a pci root
>> bus, but returns without setting the is_added flag. The is_added flag
>> for a pci root bus will be set by function pci_scan_child_bus().
>
>> If a pci root bus is destroyed before calling pci_scan_child_bus(),
>> the is_added flag will not be set.
>
> how that can be met?
>
> Do we have pci_remove_rescan_mutex around them?
>
> Yinghai
>
>
next prev parent reply other threads:[~2012-03-13 7:24 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-11 17:48 [RFC PATCH 0/5] PCI: introduce hotplug safe bus searching interfaces Jiang Liu
2012-03-11 17:48 ` [PATCH 1/5] Fix device reference count leakage in pci_dev_present() Jiang Liu
2012-03-11 17:48 ` [PATCH 2/5] Correctly clean up pci root buses in function pci_remove_bus() Jiang Liu
2012-03-13 6:24 ` Yinghai Lu
2012-03-13 7:23 ` Jiang Liu [this message]
2012-03-11 17:48 ` [PATCH 3/5] Fix an access-after-free issue in function pci_stop_and_remove_bus() Jiang Liu
2012-03-13 3:47 ` Bjorn Helgaas
2012-03-11 17:48 ` [RFC PATCH 4/5] PCI: Introduce hotplug-safe pci bus searching interfaces Jiang Liu
2012-03-13 3:49 ` Bjorn Helgaas
2012-03-13 8:13 ` Jiang Liu
2012-03-11 17:48 ` [RFC PATCH 5/5] PCI: Replace old pci bus searching function calls with hotplug safe ones Jiang Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F5EF5F2.2000507@huawei.com \
--to=jiang.liu@huawei.com \
--cc=ashok.raj@intel.com \
--cc=bhelgaas@google.com \
--cc=chenkeping@huawei.com \
--cc=jbarnes@virtuousgeek.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=liuj97@gmail.com \
--cc=suresh.b.siddha@intel.com \
--cc=yinghai@kernel.org \
--cc=youquan.song@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).