From: Adrian Hunter <adrian.hunter@intel.com>
To: Alexander Stein <alexander.stein@systec-electronic.com>
Cc: Chris Ball <cjb@laptop.org>,
Jesse Barnes <jbarnes@virtuousgeek.org>,
linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-pci@vger.kernel.org
Subject: Re: [PATCH v2] mmc: sdhci: check interrupt flags in ISR again
Date: Wed, 14 Mar 2012 11:23:27 +0200 [thread overview]
Message-ID: <4F60638F.20300@intel.com> (raw)
In-Reply-To: <1331715130-8505-1-git-send-email-alexander.stein@systec-electronic.com>
On 14/03/12 10:52, Alexander Stein wrote:
> When using MSI it is possible that a new MSI is sent while an earlier
> MSI is currently handled. In this case SDHCI_INT_STATUS only contains
> SDHCI_INT_RESPONSE and the ISR would not be called again. But at the end
> of the ISR SDHCI_INT_DATA_END is now also pending which would be ignored.
>
> Fix this by rereading the interrupt flags in the ISR until no interrupt
> we care is pending.
>
> Signed-off-by: Alexander Stein <alexander.stein@systec-electronic.com>
> ---
> Changes in v2:
> * rearranged code a bit and added a maximum loop counter as suggested
> by Adrian
>
> drivers/mmc/host/sdhci.c | 19 ++++++++++++-------
> 1 files changed, 12 insertions(+), 7 deletions(-)
Acked-by: Adrian Hunter <adrian.hunter@intel.com>
next prev parent reply other threads:[~2012-03-14 9:24 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-13 17:16 [PATCH 1/3] mmc: sdhci-pci: Add MSI support Alexander Stein
2012-03-13 17:16 ` [PATCH 2/3] mmc: sdhci: check interrupt flags in ISR again Alexander Stein
2012-03-14 7:39 ` Adrian Hunter
2012-03-14 7:53 ` Alexander Stein
2012-03-14 8:13 ` Adrian Hunter
2012-03-14 8:52 ` [PATCH v2] " Alexander Stein
2012-03-14 9:23 ` Adrian Hunter [this message]
2012-03-13 17:16 ` [PATCH 3/3] mmc: sdhci-pci: allow 8-bit bus width for Intel PCH Alexander Stein
2012-03-13 17:25 ` Greg KH
2012-03-14 7:38 ` [PATCH v2] " Alexander Stein
2012-03-14 1:17 ` [PATCH 3/3] " Tomoya MORINAGA
2012-03-14 7:26 ` Alexander Stein
2012-03-16 3:41 ` [PATCH 1/3] mmc: sdhci-pci: Add MSI support Chris Ball
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F60638F.20300@intel.com \
--to=adrian.hunter@intel.com \
--cc=alexander.stein@systec-electronic.com \
--cc=cjb@laptop.org \
--cc=jbarnes@virtuousgeek.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).