From: Don Dutile <ddutile@redhat.com>
To: Matthew Wilcox <matthew@wil.cx>
Cc: "Hao, Xudong" <xudong.hao@intel.com>,
Bjorn Helgaas <bhelgaas@google.com>,
"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>
Subject: Re: [PATCH V4] Quirk for IVB graphics FLR errata
Date: Thu, 12 Apr 2012 11:19:42 -0400 [thread overview]
Message-ID: <4F86F28E.8020807@redhat.com> (raw)
In-Reply-To: <20120412040630.GC6557@parisc-linux.org>
On 04/12/2012 12:06 AM, Matthew Wilcox wrote:
> On Wed, Apr 11, 2012 at 10:28:13AM -0400, Don Dutile wrote:
>>> + cycles_t cyc_op_timeout = tsc_khz*op_timeout*1000;
>> Don't we know how to do a 10sec timeout w/o tying it to tsc_khz?
>
> Right, this code should of course be using jiffies and msleep.
>
>> --> other arch compile problem source???
>
> Well, this device is part of the x86 CPU. It's never going to be found
> as part of any other architecture. Why force other architectures to
> carry this quirk around?
>
>
Well, the trend to include more IO into chipsets tied to an arch
will probably increase over time, so such conditional quirks will
increase as well.
Sounds like the quirk tables need an arch-hook (linked list) to check
& traverse. Then such code can go into arch/<arch>/pci/quirks.c .
I was under the impression Linux prefers not to have ifdef <arch> in
common code modules, and to split it out under arch/<> .
next prev parent reply other threads:[~2012-04-12 15:19 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-11 6:03 [PATCH V4] Quirk for IVB graphics FLR errata Hao, Xudong
2012-04-11 12:22 ` Matthew Wilcox
2012-04-12 2:26 ` Hao, Xudong
2012-04-11 14:28 ` Don Dutile
2012-04-12 2:12 ` Hao, Xudong
2012-04-12 4:06 ` Matthew Wilcox
2012-04-12 15:19 ` Don Dutile [this message]
2012-04-13 1:40 ` Hao, Xudong
2012-04-13 1:48 ` Bjorn Helgaas
2012-04-13 13:48 ` Don Dutile
2012-04-13 1:56 ` Hao, Xudong
-- strict thread matches above, loose matches on Subject: below --
2012-03-01 9:37 Hao, Xudong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F86F28E.8020807@redhat.com \
--to=ddutile@redhat.com \
--cc=bhelgaas@google.com \
--cc=linux-pci@vger.kernel.org \
--cc=matthew@wil.cx \
--cc=xudong.hao@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).