From: Jan Kiszka <jan.kiszka@web.de>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: "linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
Bjorn Helgaas <bhelgaas@google.com>,
Alexey Kardashevskiy <aik@ozlabs.ru>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Alex Williamson <alex.williamson@redhat.com>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
David Gibson <david@gibson.dropbear.id.au>,
Alexander Graf <agraf@suse.de>, kvm <kvm@vger.kernel.org>
Subject: Re: [PATCH] PCI: Mark INTx masking support of Chelsio T310 10GbE NIC as broken
Date: Mon, 28 May 2012 14:51:25 +0200 [thread overview]
Message-ID: <4FC374CD.5000509@web.de> (raw)
In-Reply-To: <20120528123934.GB21778@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 815 bytes --]
On 2012-05-28 14:39, Michael S. Tsirkin wrote:
> On Fri, May 25, 2012 at 11:02:13AM -0300, Jan Kiszka wrote:
>> According to Alexey, the T310 does not properly support INTx masking as
>> it fails to keep the PCI_STATUS_INTERRUPT bit updated once the interrupt
>> is masked. Mark this adapter as broken so that pci_intx_mask_supported
>> won't report it as compatible.
>>
>> Reported-by: Alexey Kardashevskiy <aik@ozlabs.ru>
>> Signed-off-by: Jan Kiszka <jan.kiszka@web.de>
>
>
> Just a thought: would be nice to have a way to discover
> the quirk was activated. Add an attribute so that
> userspace can detect and report this properly to users?
> Or just log a warning message ...
pr_notice_once? A flag for userspace would be significantly more
complicated (and not PCI layer hands).
Jan
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 262 bytes --]
next prev parent reply other threads:[~2012-05-28 12:51 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-25 14:02 [PATCH] PCI: Mark INTx masking support of Chelsio T310 10GbE NIC as broken Jan Kiszka
2012-05-25 14:11 ` Bjorn Helgaas
2012-05-25 14:20 ` Jan Kiszka
2012-05-28 12:39 ` Michael S. Tsirkin
2012-05-28 12:51 ` Jan Kiszka [this message]
2012-05-28 13:21 ` Michael S. Tsirkin
2012-05-28 13:29 ` Jan Kiszka
2012-05-28 13:39 ` Michael S. Tsirkin
2012-05-29 7:51 ` Jan Kiszka
2012-05-29 9:51 ` Michael S. Tsirkin
2012-06-05 14:38 ` Jan Kiszka
2012-06-07 5:14 ` Alexey Kardashevskiy
2012-06-07 8:30 ` [PATCH v2] " Jan Kiszka
2012-06-18 18:29 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FC374CD.5000509@web.de \
--to=jan.kiszka@web.de \
--cc=agraf@suse.de \
--cc=aik@ozlabs.ru \
--cc=alex.williamson@redhat.com \
--cc=benh@kernel.crashing.org \
--cc=bhelgaas@google.com \
--cc=david@gibson.dropbear.id.au \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=mst@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).