From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CCA35C433DF for ; Fri, 26 Jun 2020 14:31:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A822920836 for ; Fri, 26 Jun 2020 14:31:44 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=nvidia.com header.i=@nvidia.com header.b="BJ+boJUZ" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725793AbgFZObo (ORCPT ); Fri, 26 Jun 2020 10:31:44 -0400 Received: from hqnvemgate24.nvidia.com ([216.228.121.143]:3396 "EHLO hqnvemgate24.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725778AbgFZObn (ORCPT ); Fri, 26 Jun 2020 10:31:43 -0400 Received: from hqpgpgate101.nvidia.com (Not Verified[216.228.121.13]) by hqnvemgate24.nvidia.com (using TLS: TLSv1.2, DES-CBC3-SHA) id ; Fri, 26 Jun 2020 07:30:08 -0700 Received: from hqmail.nvidia.com ([172.20.161.6]) by hqpgpgate101.nvidia.com (PGP Universal service); Fri, 26 Jun 2020 07:31:43 -0700 X-PGP-Universal: processed; by hqpgpgate101.nvidia.com on Fri, 26 Jun 2020 07:31:43 -0700 Received: from [10.40.205.13] (172.20.13.39) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Fri, 26 Jun 2020 14:31:37 +0000 Subject: Re: [RFC] PCI: tegra: Revert raw_violation_fixup for tegra124 To: Nicolas Chauvet CC: Thierry Reding , Jonathan Hunter , Lorenzo Pieralisi , , References: <20200420164304.28810-1-kwizart@gmail.com> <680b456a-b1ed-45f6-aa38-6ec49783af6d@nvidia.com> X-Nvconfidentiality: public From: Manikanta Maddireddy Message-ID: <4acabca8-e2fc-b660-0c37-c5f332b99084@nvidia.com> Date: Fri, 26 Jun 2020 20:00:13 +0530 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.9.0 MIME-Version: 1.0 In-Reply-To: X-Originating-IP: [172.20.13.39] X-ClientProxiedBy: HQMAIL107.nvidia.com (172.20.187.13) To HQMAIL107.nvidia.com (172.20.187.13) Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Content-Language: en-US DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1593181808; bh=rfotPtR65lcNl8JsC77pG5+W18C3D6C7K31DVG1cqEQ=; h=X-PGP-Universal:Subject:To:CC:References:X-Nvconfidentiality:From: Message-ID:Date:User-Agent:MIME-Version:In-Reply-To: X-Originating-IP:X-ClientProxiedBy:Content-Type: Content-Transfer-Encoding:Content-Language; b=BJ+boJUZ2JgAN8Pial9Ox17ZWvxk19YuxM+bOK1vwqZw5u7fBJKnrqEsAS197WEZ/ I4IS/urUZl0KRlpbEZK9wvCthhZ0Yb+QMbaTnReCYzaIlYgI6kv4D0/00YKSazu87Y htxWG4jpN1TAfvDmn/QN07y+wsDaCe81QfyGBlBxAeKJpnji7EISfMpOf/Hc38pXlT ODRrqSMhoMCZrgOWqlmLGJVssZvm3if/2/boJUjK/jd4j7dM6ygbGK7HjmGDWbcq4C MS/SiKM5p5miq/3k35CMPb995VGze1hO34xnN663W73Zg2NMuWocdlU8lElCpeCfRT 7g1hB/FJdgUAQ== Sender: linux-pci-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org On 26-Jun-20 6:52 PM, Nicolas Chauvet wrote: > External email: Use caution opening links or attachments > > > Le lun. 20 avr. 2020 =C3=A0 20:16, Manikanta Maddireddy > a =C3=A9crit : >> Thank you Nicolas for identifying the patch which caused the CmpltTO. >> >> Little background on the fixup, >> In the internal testing with dGPU on Tegra124, CmplTO is reported by >> dGPU. This happened because FIFO queue in AFI(AXI to PCIe) module >> get full by upstream posted writes. Back to back upstream writes >> interleaved with infrequent reads, triggers RAW violation and CmpltTO. >> This is fixed by reducing the posted write credits and by changing >> updateFC timer frequency. These settings are fixed after stress test. >> >> In the current case, RTL NIC is also reporting CmplTO. These settings >> seems to be aggravating the issue instead of fixing it. > Seems I've lost track of this issue. > > @Manikanta Maddireddy Do you plan to have some time to work on this ? Unfortunately, I don't have access to T124 platform because of lock down. > If going with the revert I wonder if I need to revert more completely > the original patch ? Since only tegra124 used the raw_violation_fixup, > should I remove this case and the related function completely or leave > the code as is ? (there will be few unused functions maybe). Given > other fixup have been added at a later time, the full revert is less > trivial. There are no unused functions, small piece of code under raw_violation_fixu= p check will become redundant. Yes, revert will give conflicts. I may not get a chance to work on this bug in coming months. If possible, please do complete revert. Once I get a chance to work on this bug, I will send out new patch. -Manikanta > > Right now this partial revert is enough to work reliably with the device. > > Thanks for your advice. > I will send a non-RFC version then.