From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Lucas Tanure <lucas.tanure@collabora.com>,
Vinod Koul <vkoul@kernel.org>,
Kishon Vijay Abraham I <kishon@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Heiko Stuebner <heiko@sntech.de>,
Thomas Gleixner <tglx@linutronix.de>,
Marc Zyngier <maz@kernel.org>,
Lorenzo Pieralisi <lpieralisi@kernel.org>,
Krzysztof Wilczynski <kw@linux.com>,
Bjorn Helgaas <bhelgaas@google.com>
Cc: Qu Wenruo <wqu@suse.com>,
Piotr Oniszczuk <piotr.oniszczuk@gmail.com>,
Peter Geis <pgwipeout@gmail.com>,
Kever Yang <kever.yang@rock-chips.com>,
linux-phy@lists.infradead.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org,
linux-pci@vger.kernel.org, kernel@collabora.com
Subject: Re: [PATCH 1/4] dt-bindings: PCI: dwc: Add rk3588 compatible line
Date: Tue, 14 Mar 2023 12:18:04 +0100 [thread overview]
Message-ID: <4ca61aac-a901-1bfa-6cf4-8c2917621667@linaro.org> (raw)
In-Reply-To: <20230313153953.422375-2-lucas.tanure@collabora.com>
On 13/03/2023 16:39, Lucas Tanure wrote:
> RK3588 uses the same driver as RK3568
Subject: drop line
Commit msg: drop driver and focus on hardware. Missing full stop.
>
> Signed-off-by: Lucas Tanure <lucas.tanure@collabora.com>
> ---
> Documentation/devicetree/bindings/pci/rockchip-dw-pcie.yaml | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/pci/rockchip-dw-pcie.yaml b/Documentation/devicetree/bindings/pci/rockchip-dw-pcie.yaml
> index 2be72ae1169f..91aa9070ee31 100644
> --- a/Documentation/devicetree/bindings/pci/rockchip-dw-pcie.yaml
> +++ b/Documentation/devicetree/bindings/pci/rockchip-dw-pcie.yaml
> @@ -23,6 +23,7 @@ properties:
> compatible:
> items:
> - const: rockchip,rk3568-pcie
> + - const: rockchip,rk3588-pcie
According to your driver change, these are compatible, so maybe this
should be expressed in the bindings?
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-03-14 11:19 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-13 15:39 [PATCH 0/4] Add PCIe2 driver support for Rockchip Lucas Tanure
2023-03-13 15:39 ` [PATCH 1/4] dt-bindings: PCI: dwc: Add rk3588 compatible line Lucas Tanure
2023-03-14 11:18 ` Krzysztof Kozlowski [this message]
2023-03-13 15:39 ` [PATCH 2/4] PCI: rockchip-dwc: " Lucas Tanure
2023-03-14 11:16 ` Krzysztof Kozlowski
2023-03-13 15:39 ` [PATCH 3/4] dt-bindings: phy: rockchip: " Lucas Tanure
2023-03-13 15:39 ` [PATCH 4/4] phy: rockchip: Add naneng combo phy support for RK3588 Lucas Tanure
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4ca61aac-a901-1bfa-6cf4-8c2917621667@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=bhelgaas@google.com \
--cc=devicetree@vger.kernel.org \
--cc=heiko@sntech.de \
--cc=kernel@collabora.com \
--cc=kever.yang@rock-chips.com \
--cc=kishon@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=kw@linux.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=lpieralisi@kernel.org \
--cc=lucas.tanure@collabora.com \
--cc=maz@kernel.org \
--cc=pgwipeout@gmail.com \
--cc=piotr.oniszczuk@gmail.com \
--cc=robh+dt@kernel.org \
--cc=tglx@linutronix.de \
--cc=vkoul@kernel.org \
--cc=wqu@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).