From: Hans Zhang <18255117159@163.com>
To: Lukas Wunner <lukas@wunner.de>
Cc: lpieralisi@kernel.org, kwilczynski@kernel.org,
bhelgaas@google.com, helgaas@kernel.org, mani@kernel.org,
robh@kernel.org, sashal@kernel.org, linux-pci@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] pci: cadence-ep: Fix incorrect MSI capability ID
Date: Fri, 10 Oct 2025 22:38:58 +0800 [thread overview]
Message-ID: <4d1389e7-5099-45da-962c-ac0446ad96c0@163.com> (raw)
In-Reply-To: <aOi48Vt_hfNvwA6t@wunner.de>
On 2025/10/10 15:42, Lukas Wunner wrote:
> On Fri, Oct 10, 2025 at 12:10:11AM +0800, Hans Zhang wrote:
>> In a previous change, the MSIX capability ID (PCI_CAP_ID_MSIX)
>> was mistakenly used when trying to locate the MSI capability in
>> cdns_pcie_ep_get_msi(). Thisis incorrect as the function handles
>> MSI functionality, not MSIX.
>>
>> Fix this by replacing PCI_CAP_ID_MSIX with the correct MSI capability
>> ID(PCI_CAP_ID_MSI) when calling cdns_pcie_find_capability(). This
>> ensures theMSI capability is properly located, allowing MSI functionality
>> to work asintended.
>>
>> Signed-off-by: Hans Zhang <18255117159@163.com>
>
> Fixes: 907912c1daa7 ("PCI: cadence: Use cdns_pcie_find_*capability() to avoid hardcoding offsets")
> Reported-by: Sasha Levin <sashal@kernel.org>
> Closes: https://lore.kernel.org/r/aOfMk9BW8BH2P30V@laps/
>
> This is material for the "pci/for-linus" branch.
Dear Lukas,
Thank you very much, Lukas. I will send the next version and add it.
Best regards,
Hans
prev parent reply other threads:[~2025-10-10 14:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-09 16:10 [PATCH] pci: cadence-ep: Fix incorrect MSI capability ID Hans Zhang
2025-10-10 7:42 ` Lukas Wunner
2025-10-10 14:38 ` Hans Zhang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4d1389e7-5099-45da-962c-ac0446ad96c0@163.com \
--to=18255117159@163.com \
--cc=bhelgaas@google.com \
--cc=helgaas@kernel.org \
--cc=kwilczynski@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lpieralisi@kernel.org \
--cc=lukas@wunner.de \
--cc=mani@kernel.org \
--cc=robh@kernel.org \
--cc=sashal@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox