Linux PCI subsystem development
 help / color / mirror / Atom feed
From: Paul Menzel <pmenzel@molgen.mpg.de>
To: Bjorn Helgaas <helgaas@kernel.org>
Cc: Bjorn Helgaas <bhelgaas@google.com>,
	linux-pci@vger.kernel.org, Yunsheng Lin <linyunsheng@huawei.com>
Subject: Re: Linux warns `Unknown NUMA node; performance will be reduced`
Date: Mon, 10 Jun 2024 22:27:37 +0200	[thread overview]
Message-ID: <4dcdc648-e09d-4f43-a53c-bcb4f54ef476@molgen.mpg.de> (raw)
In-Reply-To: <20240610194236.GA954050@bhelgaas>

Dear Bjorn,


Am 10.06.24 um 21:42 schrieb Bjorn Helgaas:
> [+cc Yunsheng, thread at
> https://lore.kernel.org/r/a154f694-c48b-4b3b-809f-4b74ec86a924@molgen.mpg.de]
> 
> Thanks very much for this report!

Thank you for the quick reply.

> On Sun, Jun 09, 2024 at 10:31:05AM +0200, Paul Menzel wrote:
>> On the servers below Linux warns:
>>
>>       Unknown NUMA node; performance will be reduced
> 
> This warning was added by ad5086108b9f ("PCI: Warn if no host bridge
> NUMA node info"), which appeared in v5.5, so I assume this isn't new.
> 
> That commit log says:
> 
>    In pci_call_probe(), we try to run driver probe functions on the node where
>    the device is attached.  If we don't know which node the device is attached
>    to, the driver will likely run on the wrong node.  This will still work,
>    but performance will not be as good as it could be.
> 
>    On NUMA systems, warn if we don't know which node a PCI host bridge is
>    attached to.  This is likely an indication that ACPI didn't supply a _PXM
>    method or the DT didn't supply a "numa-node-id" property.
> 
> I assume these are all ACPI systems, so likely missing _PXM.  An
> acpidump could confirm this.

I created an issue in the Linux Kernel Bugzilla [1] and attached the 
output of `acpidump` on a Dell PowerEdge T630 there. The DSDT contains:

         Device (PCI1)
         {
         […]
             Method (_PXM, 0, NotSerialized)  // _PXM: Device Proximity
             {
                 If ((CLOD == 0x00))
                 {
                     Return (0x01)
                 }
                 Else
                 {
                     Return (0x02)
                 }
             }
         […]
         }

> I think the devices on buses 7f and ff are Intel chipset devices, and
> I doubt we have drivers for any of them.  They have vendor/device IDs
> of 8086:6fXX, and I didn't see any reference to them:
> 
>    $ git grep -i \<0x6f..\>
>    $

Interesting. Any ideas, what these chipset devices do?

> If we *did* have drivers, they would certainly benefit from having
> _PXM, but since there are no probe methods, I don't think it matters
> that we don't know where they should run.
> 
> Maybe the message should be downgraded from "dev_warn" to "dev_info"
> since there's no functional problem, and the user can't really do
> anything about it.
> 
> We could also consider moving it to the actual probe path, so we don't
> emit a message unless there is an affected driver.

Both ideas sound good, but I do not know the code at all.

>> 1.  [    0.000000] DMI: Dell Inc. PowerEdge R730/0H21J3, BIOS 2.13.0 05/14/2021
>> 2.  [    0.000000] DMI: Dell Inc. PowerEdge R730/0H21J3, BIOS 2.2.5 09/06/2016
>> 3.  [    0.000000] DMI: Dell Inc. PowerEdge R730xd/0WCJNT, BIOS 2.3.4 11/08/2016
>> 4.  [    0.000000] DMI: Dell Inc. PowerEdge R910/0KYD3D, BIOS 2.10.0 08/29/2013
>> 5.  [    0.000000] DMI: Dell Inc. PowerEdge R930/0T55KM, BIOS 2.8.1 01/02/2020
>> 6.  [    0.000000] DMI: Dell Inc. PowerEdge T630/0NT78X, BIOS 2.5.4 08/17/2017
>> 7.  [    0.000000] DMI: Dell Inc. PowerEdge T630/0W9WXC, BIOS 1.5.4 10/04/2015
>> 8.  [    0.000000] DMI: Dell Inc. PowerEdge T630/0W9WXC, BIOS 2.11.0 12/23/2019
>> 9.  [    0.000000] DMI: Dell Inc. PowerEdge T630/0W9WXC, BIOS 2.1.5 04/13/2016
>> 10. [    0.000000] DMI: Supermicro Super Server/X13SAE, BIOS 2.0 10/17/2022
>> ...
> 
>> 7f:08.0 System peripheral [0880]: Intel Corporation Xeon E7 v4/Xeon E5 v4/Xeon E3 v4/Xeon D QPI Link 0 [8086:6f80] (rev 01)
>> 7f:08.2 Performance counters [1101]: Intel Corporation Xeon E7 v4/Xeon E5 v4/Xeon E3 v4/Xeon D QPI Link 0 [8086:6f32] (rev 01)
>> ...
> 
>> ff:08.0 System peripheral [0880]: Intel Corporation Xeon E7 v4/Xeon E5 v4/Xeon E3 v4/Xeon D QPI Link 0 [8086:6f80] (rev 01)
>> ff:08.2 Performance counters [1101]: Intel Corporation Xeon E7 v4/Xeon E5 v4/Xeon E3 v4/Xeon D QPI Link 0 [8086:6f32] (rev 01)
>> ...
> 
> 
>> [    0.000000] DMI: Dell Inc. PowerEdge T630/0NT78X, BIOS 2.4.2 01/09/2017
>> ...
>> [    4.398627] ACPI: PCI Root Bridge [UNC1] (domain 0000 [bus ff])
>> [    4.437865] pci_bus 0000:ff: Unknown NUMA node; performance will be reduced
>> ...
>> [    4.901021] ACPI: PCI Root Bridge [UNC0] (domain 0000 [bus 7f])
>> [    4.940865] pci_bus 0000:7f: Unknown NUMA node; performance will be reduced


Kind regards,

Paul


[1]: https://bugzilla.kernel.org/show_bug.cgi?id=218951

  reply	other threads:[~2024-06-10 20:28 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-09  8:31 Linux warns `Unknown NUMA node; performance will be reduced` Paul Menzel
2024-06-10 19:42 ` Bjorn Helgaas
2024-06-10 20:27   ` Paul Menzel [this message]
2024-06-11  3:05     ` Yunsheng Lin
2024-06-11 22:31       ` Bjorn Helgaas
2025-08-05 21:39         ` Paul Menzel
2024-06-11 15:11     ` Bjorn Helgaas
2024-06-18 15:19       ` Paul Menzel
2026-03-03 21:55 ` Bjorn Helgaas
2026-03-04  1:34   ` Yunsheng Lin
2026-03-04 21:18     ` Bjorn Helgaas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4dcdc648-e09d-4f43-a53c-bcb4f54ef476@molgen.mpg.de \
    --to=pmenzel@molgen.mpg.de \
    --cc=bhelgaas@google.com \
    --cc=helgaas@kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=linyunsheng@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox