From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8AE9AC43219 for ; Thu, 19 May 2022 15:06:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237679AbiESPGr (ORCPT ); Thu, 19 May 2022 11:06:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58722 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240661AbiESPGm (ORCPT ); Thu, 19 May 2022 11:06:42 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 413DB4EA28 for ; Thu, 19 May 2022 08:06:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1652972801; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=6cukqKLlYVO6UiHSZMrtRJgoast0/luZetDqiqEdUko=; b=JuRsPyE/6yd87aXDGGXsCXMbaSPJxtbOuowTigP+hV2HGuoLuoS14E7lUPXeWhdTVsobjV IE4yHbZyctXnh7YasNo+HbNNsQxhOD5A4KshRNMNc3+YX0PIzVPnKjKgp99a1SjCB/ICt/ RaEW76AZtSBDUn+V6wi1Jyx6icaamC4= Received: from mail-ej1-f72.google.com (mail-ej1-f72.google.com [209.85.218.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-19-fxOUkwWdPgKXyJRL6S0KFA-1; Thu, 19 May 2022 11:06:39 -0400 X-MC-Unique: fxOUkwWdPgKXyJRL6S0KFA-1 Received: by mail-ej1-f72.google.com with SMTP id pj21-20020a170906d79500b006fea2020e78so346888ejb.11 for ; Thu, 19 May 2022 08:06:39 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=6cukqKLlYVO6UiHSZMrtRJgoast0/luZetDqiqEdUko=; b=wCLjdECMy8ip5Nv4Ja37wvGSQn1W42fVRJFHFnH+IjKknZYaN5CRJHeg9hlZLPOTZT DIuBhwRR7dYfx/qHPgHhG1RT2usGLzm6f7tb3owO9fnMgQAoCjGV6hRyNN+GY0HDXpkY InTCAKV6woHnSfuY1OX21f1yEkY4bqoclq/FUMI7qLl9dVwL1HFivPOBDRvSxbqb2Yw3 YCJpAZu8hsQ9Sz1HbSWqSlDsh0hBicncEqrKU0tlfBkXtvf5YfYfsM9wGMq5A2xpCnPL +eXDi15RGP7uMfIt74lDn99iOvHoJ/9v7PFtrzF06uZgS8xAaUegI7UgkW02+qgLYxB+ h7+w== X-Gm-Message-State: AOAM531LJwAbzpu0cf+0O8F8GL9x3CjbSKZUQolutkPzCmmRz7kIlabU qMZ3uycS77+ZMvEZuSd0ncol+CGJQpDhHJRW5OFS4meO8JPqjhNyCq4PxQzC1fad6brh4toVPiI p0CLwyskg5DkI4cxNxNRQ X-Received: by 2002:a17:906:ece3:b0:6f3:da10:138a with SMTP id qt3-20020a170906ece300b006f3da10138amr4833736ejb.438.1652972798596; Thu, 19 May 2022 08:06:38 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxNOoQNKVItf73DSDM0VafoQHW0cH49Hzz2nXR7wvug3z2zrL8Tzk3+pUB5ClBDB3sbRS2J6Q== X-Received: by 2002:a17:906:ece3:b0:6f3:da10:138a with SMTP id qt3-20020a170906ece300b006f3da10138amr4833709ejb.438.1652972798316; Thu, 19 May 2022 08:06:38 -0700 (PDT) Received: from ?IPV6:2001:1c00:c1e:bf00:d69d:5353:dba5:ee81? (2001-1c00-0c1e-bf00-d69d-5353-dba5-ee81.cable.dynamic.v6.ziggo.nl. [2001:1c00:c1e:bf00:d69d:5353:dba5:ee81]) by smtp.gmail.com with ESMTPSA id c6-20020a056402120600b0042aa6a43ccdsm2953894edw.28.2022.05.19.08.06.37 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 19 May 2022 08:06:37 -0700 (PDT) Message-ID: <4f10c3aa-5eca-ee00-6b9e-f152ffdcca7f@redhat.com> Date: Thu, 19 May 2022 17:06:37 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 Subject: Re: [PATCH v7 1/1] x86/PCI: Ignore E820 reservations for bridge windows on newer systems Content-Language: en-US To: Bjorn Helgaas Cc: "Rafael J . Wysocki" , Mika Westerberg , =?UTF-8?Q?Krzysztof_Wilczy=c5=84ski?= , Bjorn Helgaas , Myron Stowe , Juha-Pekka Heikkila , Thomas Gleixner , Ingo Molnar , Borislav Petkov , "H . Peter Anvin" , =?UTF-8?Q?Benoit_Gr=c3=a9goire?= , Hui Wang , linux-acpi@vger.kernel.org, linux-pci@vger.kernel.org, x86@kernel.org, linux-kernel@vger.kernel.org References: <20220519144923.GA22233@bhelgaas> From: Hans de Goede In-Reply-To: <20220519144923.GA22233@bhelgaas> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org Hi Bjorn, On 5/19/22 16:49, Bjorn Helgaas wrote: > On Thu, May 19, 2022 at 04:29:43PM +0200, Hans de Goede wrote: >> Hi, >> >> On 5/19/22 16:14, Bjorn Helgaas wrote: >>> On Thu, May 19, 2022 at 04:01:48PM +0200, Hans de Goede wrote: >>> >>>> Ok, I'll go and prepare a v9 and I will submit that later today. >>> >>> Would it be practical to split into three patches? >>> >>> 1) Add command-line args >>> 2) Add DMI quirks >>> 3) Add date check >>> >>> It seems easier to assimilate and document in smaller pieces, if >>> that's possible. >> >> Ack, will do. Note this will cause quite a bit of copy/paste >> in the commit msg to explain why these changes are necessary. > > OK, if the repetition gets excessive I can squash them back > together. Hopefully the main explanation can go in the first patch, > the second can just mention the fact that these machines need the > exception, and the third can focus on the plan for the future. I'm almost done with prepping v9 and atm there is a 17 line introduction of the problem which is shared between all 3 patches in the commit msg. I personally don't think this is too bad, but feel free to shorten it a bit in patch 2 + 3 before merging these. I think the split makes sense, so I would prefer you amending the commit msg over squashing them back together again. Regards, Hans