From: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
To: Yazen Ghannam <yazen.ghannam@amd.com>
Cc: "Bjorn Helgaas" <bhelgaas@google.com>,
linux-pci@vger.kernel.org, "Krzysztof Wilczyński" <kw@linux.com>,
"Lukas Wunner" <lukas@wunner.de>,
"Jonathan Cameron" <Jonathan.Cameron@huawei.com>,
"Mahesh J Salgaonkar" <mahesh@linux.ibm.com>,
"Oliver O'Halloran" <oohall@gmail.com>,
linuxppc-dev@lists.ozlabs.org,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v7 8/8] PCI/AER: Add prefixes to printouts
Date: Wed, 18 Dec 2024 16:15:34 +0200 (EET) [thread overview]
Message-ID: <4f5e8d07-d459-7a8e-844e-6f1b432763fe@linux.intel.com> (raw)
In-Reply-To: <20241217215545.GB1121691@yaz-khff2.amd.com>
[-- Attachment #1: Type: text/plain, Size: 1001 bytes --]
On Tue, 17 Dec 2024, Yazen Ghannam wrote:
> On Tue, Dec 17, 2024 at 03:53:58PM +0200, Ilpo Järvinen wrote:
> > Only part of the AER diagnostic printouts use "AER:" prefix because
> > they use low-level pci_printk() directly to allow selecting level.
> >
> > Add "AER:" prefix to lines that are printed with pci_printk().
>
> Can we please include the "HW_ERR" prefix also? IMO, it would make the
> kernel messages more consistent if all hardware error info had it.
While I'm not against your suggestion, it doesn't belong into this patch
as there are other lines beyond those touched in this patch that would
need to have HW_ERR as well.
I think I'll just drop this patch from this series and move it into the
pci_printk() series to avoid the inter-series conflict. Adding the HW_ERR
change would conflict badly with Karolina Stolarek's series so I'm not
sure if I want to pursue that change at this point (it's only my todo
list so it won't get forgotten).
--
i.
prev parent reply other threads:[~2024-12-18 14:19 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-17 13:53 [PATCH v7 0/8] PCI: Consolidate TLP Log reading and printing Ilpo Järvinen
2024-12-17 13:53 ` [PATCH v7 1/8] PCI: Don't expose pcie_read_tlp_log() outside of PCI subsystem Ilpo Järvinen
2024-12-17 13:53 ` [PATCH v7 2/8] PCI: Move TLP Log handling to own file Ilpo Järvinen
2024-12-17 13:53 ` [PATCH v7 3/8] PCI: Make pcie_read_tlp_log() signature same Ilpo Järvinen
2024-12-17 13:53 ` [PATCH v7 4/8] PCI: Use unsigned int i in pcie_read_tlp_log() Ilpo Järvinen
2024-12-17 13:53 ` [PATCH v7 5/8] PCI: Store # of supported End-End TLP Prefixes Ilpo Järvinen
2024-12-17 13:53 ` [PATCH v7 6/8] PCI: Add TLP Prefix reading into pcie_read_tlp_log() Ilpo Järvinen
2024-12-17 15:36 ` Ilpo Järvinen
2024-12-17 13:53 ` [PATCH v7 7/8] PCI: Create helper to print TLP Header and Prefix Log Ilpo Järvinen
2024-12-17 13:53 ` [PATCH v7 8/8] PCI/AER: Add prefixes to printouts Ilpo Järvinen
2024-12-17 21:55 ` Yazen Ghannam
2024-12-18 14:15 ` Ilpo Järvinen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4f5e8d07-d459-7a8e-844e-6f1b432763fe@linux.intel.com \
--to=ilpo.jarvinen@linux.intel.com \
--cc=Jonathan.Cameron@huawei.com \
--cc=bhelgaas@google.com \
--cc=kw@linux.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=lukas@wunner.de \
--cc=mahesh@linux.ibm.com \
--cc=oohall@gmail.com \
--cc=yazen.ghannam@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox