From: Yijing Wang <wangyijing0307@gmail.com>
To: Bjorn Helgaas <bhelgaas@google.com>
Cc: linux-pci@vger.kernel.org, Yinghai Lu <yinghai@kernel.org>
Subject: Re: Do we need acpiphp_sanitize_bus() in acpiphp?
Date: Wed, 15 Aug 2012 22:52:18 +0800 [thread overview]
Message-ID: <502BB7A2.7040304@gmail.com> (raw)
In-Reply-To: <CAErSpo4nFeDPvWeWmbXgmiRKWDNaeA44uwFbOLOWUhi-gLp5ag@mail.gmail.com>
> On Wed, Aug 15, 2012 at 7:13 AM, Yijing Wang <wangyijing0307@gmail.com> wrote:
>> Hi all,
>> I have some confusion on acpiphp_sanitize_bus() functions.If I understand wrong about this, correct me,thanks your help.
>> I think there are three problems in this function:
>> 1、Use list_for_each_entry here is not safe, because pci_stop_and_remove_bus_device() will remove the device from bus.
>> 2、If assign resources fail after hot-add a device, the resource will reset to zero, in reset_resource(), res->start = 0,
>> res->end =0, res->end = 0.
>> 3、I think leave the fail pci devices in the system is better rather than remove them, so we can see all pci devices
>> by lspci after hot-add, what about your opinion?
>
> These sound like reasonable concerns. The best thing to do is to
> propose patches (separate ones for each logical issue). Then we can
> review a concrete change and apply it if appropriate.
>
Hi Bjorn,
Thanks for your comments!
You are right, I will provide some patches as soon.
prev parent reply other threads:[~2012-08-15 14:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-15 14:13 Do we need acpiphp_sanitize_bus() in acpiphp? Yijing Wang
2012-08-15 14:27 ` Bjorn Helgaas
2012-08-15 14:52 ` Yijing Wang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=502BB7A2.7040304@gmail.com \
--to=wangyijing0307@gmail.com \
--cc=bhelgaas@google.com \
--cc=linux-pci@vger.kernel.org \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).