From: Yijing Wang <wangyijing@huawei.com>
To: Huang Ying <ying.huang@intel.com>
Cc: Bjorn Helgaas <bhelgaas@google.com>,
Chen Gong <gong.chen@linux.intel.com>, <jiang.liu@huawei.com>,
Hanjun Guo <guohanjun@huawei.com>, <linux-pci@vger.kernel.org>
Subject: Re: [PATCH 5/6] PCI/AER: introduce pci_bus_ops_free to free pci_bus_ops
Date: Wed, 19 Sep 2012 14:11:21 +0800 [thread overview]
Message-ID: <50596209.5060201@huawei.com> (raw)
In-Reply-To: <1348034627.8212.136.camel@yhuang-dev>
On 2012/9/19 14:03, Huang Ying wrote:
> On Wed, 2012-09-19 at 10:40 +0800, Yijing Wang wrote:
>> Signed-off-by: Yijing Wang <wangyijing@huawei.com>
>> ---
>> drivers/pci/pcie/aer/aer_inject.c | 14 +++++++++++---
>> 1 files changed, 11 insertions(+), 3 deletions(-)
>>
>> diff --git a/drivers/pci/pcie/aer/aer_inject.c b/drivers/pci/pcie/aer/aer_inject.c
>> index 0a12ac7..79b611d 100644
>> --- a/drivers/pci/pcie/aer/aer_inject.c
>> +++ b/drivers/pci/pcie/aer/aer_inject.c
>> @@ -162,6 +162,16 @@ static struct pci_bus_ops *pci_bus_ops_pop(void)
>> return bus_ops;
>> }
>>
>> +static void pci_bus_ops_free(void)
>> +{
>> + struct pci_bus_ops *bus_ops, *tmp_ops;
>> +
>> + list_for_each_entry_safe(bus_ops, tmp_ops, &pci_bus_ops_list, list) {
>> + list_del(&bus_ops->list);
>> + kfree(bus_ops);
>> + }
>> +}
>
> IMHO, this can be inlined into aer_inject_exit
>
>> static struct pci_bus_ops *pci_bus_ops_get(struct pci_bus_ops *from)
>> {
>> struct pci_bus_ops *bus_ops = NULL;
>> @@ -641,9 +651,7 @@ static void __exit aer_inject_exit(void)
>> * module exit
>> */
>> clean_untracked_pci_ops_aer();
>> -
>> - while ((bus_ops = pci_bus_ops_pop()))
>
> You can remove pci_bus_ops_pop now.
>
OK, I will move pci_bus_ops_free inlined into aer_inject_exit and remove pci_bus_ops_pop in this patch.
> Best Regards,
> Huang Ying
>
>> - kfree(bus_ops);
>> + pci_bus_ops_free();
>>
>> spin_lock_irqsave(&inject_lock, flags);
>> list_for_each_entry_safe(err, err_next, &einjected, list) {
>
>
>
> .
>
--
Thanks!
Yijing
next prev parent reply other threads:[~2012-09-19 6:13 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-19 2:40 [PATCH 0/6] fix aer_inject bug while doing pci hot-plug Yijing Wang
2012-09-19 2:40 ` [PATCH 1/6] PCI/AER: fix pci_ops return NULL when hotplug a pci bus doing aer error inject Yijing Wang
2012-09-19 5:13 ` Huang Ying
2012-09-19 5:52 ` Yijing Wang
2012-09-19 8:19 ` Jiang Liu
2012-09-19 2:40 ` [PATCH 2/6] PCI/AER: introduce pci_bus_ops_get() function to avoid a small race condition window Yijing Wang
2012-09-19 5:52 ` Huang Ying
2012-09-19 6:42 ` Yijing Wang
2012-09-19 7:00 ` Huang Ying
2012-09-19 2:40 ` [PATCH 3/6] PCI/AER: clean all untracked pci_ops_aer when rmmod aer_inject Yijing Wang
2012-09-19 5:57 ` Huang Ying
2012-09-19 6:09 ` Yijing Wang
2012-09-19 6:18 ` Huang Ying
2012-09-19 6:36 ` Yijing Wang
2012-09-19 2:40 ` [PATCH 4/6] PCI/AER: clean pci_bus_ops when related pci bus was removed Yijing Wang
2012-09-19 2:40 ` [PATCH 5/6] PCI/AER: introduce pci_bus_ops_free to free pci_bus_ops Yijing Wang
2012-09-19 6:03 ` Huang Ying
2012-09-19 6:11 ` Yijing Wang [this message]
2012-09-19 7:11 ` Chen Gong
2012-09-19 7:29 ` Yijing Wang
2012-09-19 2:40 ` [PATCH 6/6] PCI/AER: clean unused code pci_bus_ops_pop Yijing Wang
2012-09-19 7:24 ` [PATCH 0/6] fix aer_inject bug while doing pci hot-plug Chen Gong
2012-09-19 7:32 ` Yijing Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50596209.5060201@huawei.com \
--to=wangyijing@huawei.com \
--cc=bhelgaas@google.com \
--cc=gong.chen@linux.intel.com \
--cc=guohanjun@huawei.com \
--cc=jiang.liu@huawei.com \
--cc=linux-pci@vger.kernel.org \
--cc=ying.huang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).