From: Randy Dunlap <rdunlap@infradead.org>
To: Don Dutile <ddutile@redhat.com>
Cc: linux-pci <linux-pci@vger.kernel.org>,
Bjorn Helgaas <bhelgaas@google.com>,
Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: [PATCH] pci: fix iov.c kernel-doc warnings
Date: Thu, 10 Jan 2013 16:53:53 -0800 [thread overview]
Message-ID: <50EF62A1.5070306@infradead.org> (raw)
In-Reply-To: <50EF3E65.3030302@redhat.com>
On 01/10/13 14:19, Don Dutile wrote:
> On 01/09/2013 08:12 PM, Randy Dunlap wrote:
>> From: Randy Dunlap<rdunlap@infradead.org>
>>
>> Fix kernel-doc warning in iov.c:
>>
>> Warning(drivers/pci/iov.c:752): No description found for parameter 'numvfs'
>>
>> Signed-off-by: Randy Dunlap<rdunlap@infradead.org>
>> ---
>> drivers/pci/iov.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> --- lnx-38-rc2.orig/drivers/pci/iov.c
>> +++ lnx-38-rc2/drivers/pci/iov.c
>> @@ -739,7 +739,7 @@ EXPORT_SYMBOL_GPL(pci_num_vf);
>> /**
>> * pci_sriov_set_totalvfs -- reduce the TotalVFs available
>> * @dev: the PCI PF device
>> - * numvfs: number that should be used for TotalVFs supported
>> + * @numvfs: number that should be used for TotalVFs supported
>> *
>> * Should be called from PF driver's probe routine with
>> * device's mutex held.
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-pci" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
> Thanks for cleanup; /my bad.
> Should checkpatch report this issue? if it does, then
> my (double-down) bad for missing that correction when I ran it against the patch.
checkpatch doesn't check for missing kernel-doc notation.
I run 'make htmldocs' on each kernel to look for kernel-doc errors
and warnings.
--
~Randy
next prev parent reply other threads:[~2013-01-11 0:52 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-10 1:12 [PATCH] pci: fix iov.c kernel-doc warnings Randy Dunlap
2013-01-10 22:19 ` Don Dutile
2013-01-11 0:53 ` Randy Dunlap [this message]
2013-01-11 18:15 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50EF62A1.5070306@infradead.org \
--to=rdunlap@infradead.org \
--cc=bhelgaas@google.com \
--cc=ddutile@redhat.com \
--cc=linux-pci@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).