From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com ([209.132.183.28]:42303 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1946959Ab3BHUqH (ORCPT ); Fri, 8 Feb 2013 15:46:07 -0500 Message-ID: <511563F6.1080009@redhat.com> Date: Fri, 08 Feb 2013 15:45:42 -0500 From: Don Dutile MIME-Version: 1.0 To: Yinghai Lu CC: Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , Bjorn Helgaas , "Rafael J. Wysocki" , linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, Joerg Roedel Subject: Re: [PATCH v2 08/26] iommu, irq: Allocate irq_desc for dmar_msi with local node References: <1360351703-20571-1-git-send-email-yinghai@kernel.org> <1360351703-20571-9-git-send-email-yinghai@kernel.org> In-Reply-To: <1360351703-20571-9-git-send-email-yinghai@kernel.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Sender: linux-pci-owner@vger.kernel.org List-ID: On 02/08/2013 02:28 PM, Yinghai Lu wrote: > iommu irq's irq_desc should be on local node ram. > > Fix the return value checking problem. > > create_irq() will return -1 when fail to allocate. > create_irq_nr() will return 0 when fail to allocate. > > here only check !irq, so need to change it to use create_irq_nr instead. > > Signed-off-by: Yinghai Lu > Cc: Joerg Roedel > Cc: Donald Dutile > --- > drivers/iommu/dmar.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/iommu/dmar.c b/drivers/iommu/dmar.c > index 174bb65..316b5a2 100644 > --- a/drivers/iommu/dmar.c > +++ b/drivers/iommu/dmar.c > @@ -1263,7 +1263,7 @@ int dmar_set_interrupt(struct intel_iommu *iommu) > if (iommu->irq) > return 0; > > - irq = create_irq(); > + irq = create_irq_nr(0, iommu->node); > if (!irq) { > pr_err("IOMMU: no free vectors\n"); > return -EINVAL; Good catch! you can add my ack to it.