From: Samuli Suominen <ssuominen@gentoo.org>
To: Martin Mares <mj@ucw.cz>
Cc: Kay Sievers <kay@vrfy.org>,
Lucas De Marchi <lucas.demarchi@profusion.mobi>,
Bjorn Helgaas <bhelgaas@google.com>,
"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>
Subject: Re: lspci -k is broken with depmod from kmod since it doesn't generate modules.pcimap anymore
Date: Mon, 01 Apr 2013 17:09:45 +0300 [thread overview]
Message-ID: <51599529.1070401@gentoo.org> (raw)
In-Reply-To: <mj+md-20130401.134601.23475.albireo@ucw.cz>
On 01/04/13 16:46, Martin Mares wrote:
> Hello!
>
>> I'm looking into that. Expect a pciutils patch soon.
>
> Please check the current version in git://git.kernel.org/pub/scm/utils/pciutils/pciutils.git
>
> Looking up modules using libkmod should be fully supported.
>
> Have a nice fortnight
>
I spotted two possible problems with the commit
First, $PKG_CONFIG is not respected and call to pkg-config is hardcoded,
this is likely to break cross-compiling
Since kmod is optional even in systemd source tree, and module loading
is optional in the kernel, some embedded Linux users likely wants to
enable/disable libkmod at will, for this there should be a ./configure
flag of some sort
Thanks for your work!
- Samuli
next prev parent reply other threads:[~2013-04-01 14:10 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-26 21:31 lspci -k is broken with depmod from kmod since it doesn't generate modules.pcimap anymore Samuli Suominen
2013-03-26 22:35 ` Bjorn Helgaas
2013-03-26 22:37 ` Samuli Suominen
2013-03-26 22:44 ` Bjorn Helgaas
2013-03-27 15:11 ` Lucas De Marchi
2013-03-27 17:00 ` Kay Sievers
2013-04-01 11:45 ` Martin Mares
2013-04-01 13:46 ` Martin Mares
2013-04-01 14:09 ` Samuli Suominen [this message]
2013-04-01 19:26 ` Martin Mares
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51599529.1070401@gentoo.org \
--to=ssuominen@gentoo.org \
--cc=bhelgaas@google.com \
--cc=kay@vrfy.org \
--cc=linux-pci@vger.kernel.org \
--cc=lucas.demarchi@profusion.mobi \
--cc=mj@ucw.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox