public inbox for linux-pci@vger.kernel.org
 help / color / mirror / Atom feed
From: Phillip Susi <psusi@ubuntu.com>
To: Bjorn Helgaas <bhelgaas@google.com>
Cc: "Rafael J. Wysocki" <rjw@sisk.pl>,
	"linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>,
	Linux PCI <linux-pci@vger.kernel.org>
Subject: Re: enabling aspm on ati radeon
Date: Fri, 17 May 2013 20:15:23 -0400	[thread overview]
Message-ID: <5196C81B.8060400@ubuntu.com> (raw)
In-Reply-To: <CAErSpo5W=Zi_2s0ywfO4VPfbUfxhhCRUMn7oRhx_mi7yYpBHmw@mail.gmail.com>

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 05/17/2013 07:52 PM, Bjorn Helgaas wrote:
> setpci will write whatever you tell it to; it doesn't check any 
> constraints like "is ASPM supported?"  But the Link Capabilities 
> register is read-only per spec, so likely you won't be able to
> change that field, at least not by writing it directly.

I assume it is RO according to the PCIe spec ( buggers seem to only
allow members of pcisig to download it ), but I checked the Intel
specs for the chip ( Sandybridge ) and it's RW.  It looks like it
powers up as 00 and it's up to the bios to change it to advertise the
capability, and it seems Asus didn't bother with that.

> You can always try using setpci to set the ASPM enable bits in the 
> Link Control register on both the bridge and the device.  When 
> enabling, I think you're supposed to do the upstream end of the
> link first, then the downstream end (and the reverse for
> disabling).

One thing I don't see anywhere is a status bit showing whether it
actually *is* in L0s or L1 currently, so how to know if it's working?


-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.12 (GNU/Linux)
Comment: Using GnuPG with undefined - http://www.enigmail.net/

iQEcBAEBAgAGBQJRlsgbAAoJEJrBOlT6nu75mVEIAIsgXJjpqx5BTaocW3fJdq/D
6uqBiZxrIiwzCxHcsxyyq2gf2z1cwV/SExb8KCtjycZjXha4Y4awa1ba+1H8QnUe
YjLwRzsVSxlXUArwcUTrGQXsCYL5Q5IYejXAE0ki36Yfp5YvrKDLfuoKet76ROAY
cIGY7w202o9jfCVVoc2nskwXWCOuTgdfffD3Kjhg5eLnB/SxcCfbIWvxw7pNmlW1
bmzBNg3Mbs/UpGSFoSAOKl2/gzniMtjej3iXEuPy/gp/BjrT9ijExlaE5s4gdxom
12GgHMO/+rtvXE0yz9+zD0oL3A8dLUW9cc1+pX6kjiSz6j7V7guRicNP1Zw4TLU=
=VABF
-----END PGP SIGNATURE-----

  reply	other threads:[~2013-05-18  0:15 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <519443A1.8050905@ubuntu.com>
2013-05-16  8:58 ` enabling aspm on ati radeon Rafael J. Wysocki
2013-05-16 16:42   ` Bjorn Helgaas
     [not found]     ` <5195596C.3000406@ubuntu.com>
2013-05-17 17:31       ` Bjorn Helgaas
2013-05-17 18:04         ` Phillip Susi
2013-05-17 19:52           ` Bjorn Helgaas
2013-05-17 20:10             ` Phillip Susi
2013-05-17 20:24               ` Bjorn Helgaas
2013-05-17 21:12                 ` Phillip Susi
2013-05-17 21:28                   ` Bjorn Helgaas
2013-05-17 23:36                     ` Phillip Susi
2013-05-17 23:52                       ` Bjorn Helgaas
2013-05-18  0:15                         ` Phillip Susi [this message]
2013-05-18  0:40                           ` Bjorn Helgaas
2013-05-18  1:20                             ` Phillip Susi
2013-05-20 13:34                               ` Bjorn Helgaas
2013-05-20 20:01                                 ` Rafael J. Wysocki
2013-05-21 13:31                                   ` Phillip Susi
2013-05-21 18:50                                     ` Sebastian
2013-05-24 19:57                                   ` Phillip Susi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5196C81B.8060400@ubuntu.com \
    --to=psusi@ubuntu.com \
    --cc=bhelgaas@google.com \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=rjw@sisk.pl \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox