From: Yijing Wang <wangyijing@huawei.com>
To: David Miller <davem@davemloft.net>
Cc: <nsujir@broadcom.com>, <mchan@broadcom.com>,
<linux-pci@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<netdev@vger.kernel.org>, <guohanjun@huawei.com>,
<liuj97@gmail.com>
Subject: Re: [PATCH] tg3: remove redundant pm init code
Date: Mon, 3 Jun 2013 15:15:56 +0800 [thread overview]
Message-ID: <51AC42AC.9000606@huawei.com> (raw)
In-Reply-To: <20130603.001301.239203578028894121.davem@davemloft.net>
On 2013/6/3 15:13, David Miller wrote:
> From: Yijing Wang <wangyijing@huawei.com>
> Date: Wed, 29 May 2013 17:00:32 +0800
>
>> Pci_enable_device() will set device pm state to D0, so
>> it's no need to do it again in tg3_init_one().
>>
>> Signed-off-by: Yijing Wang <wangyijing@huawei.com>
>
> This patch introduces a warning:
>
> drivers/net/ethernet/broadcom/tg3.c: In function ‘tg3_init_one’:
> drivers/net/ethernet/broadcom/tg3.c:17231:13: warning: ‘pm_cap’ may be used uninitialized in this function [-Wuninitialized]
>
Sorry, I will update it and resend soon.
Thanks!
Yijing.
--
Thanks!
Yijing
prev parent reply other threads:[~2013-06-03 7:16 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-29 9:00 [PATCH] tg3: remove redundant pm init code Yijing Wang
2013-05-29 23:22 ` Michael Chan
2013-06-03 7:13 ` David Miller
2013-06-03 7:15 ` Yijing Wang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51AC42AC.9000606@huawei.com \
--to=wangyijing@huawei.com \
--cc=davem@davemloft.net \
--cc=guohanjun@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=liuj97@gmail.com \
--cc=mchan@broadcom.com \
--cc=netdev@vger.kernel.org \
--cc=nsujir@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).