From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 24B45A41 for ; Fri, 12 Sep 2025 10:38:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757673532; cv=none; b=WF+idchpCdx91zw7G7UY+Ar3naAOdbhv9/0IUvm0f1uODYtkYekPr8W5tlN3KYNVcZrNG28kx8cK9+BBmgnTu3lwR+4MHdDReF6ymsHdoPil4SCWwUG4hpWarmVKqOPvhJp8M2D2Bnosb9pyycrJzT4XqsPpjko5MJl5vzhVj7g= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757673532; c=relaxed/simple; bh=GCR7ls+kXPcQBL7zWMM/aZc/sGBeJxwOiy4URDM1d6s=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=DcG7na4ijChZJpN7HVVVjzrzG8zMBr8W6SZeHEmAaWqq0xODDoDjpws6R45fnNqwRyBOgU//7MLLAFDTOzAWrsq3g5HgZBeBs2G83LXPrwfVTwcJpA5YhPGgaivS15g2wI/Qf+f1zcvEJvBBHD8szoUi7qUb5aQJyMx6yO25gFA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=VTPb4rER; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="VTPb4rER" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 62190C4CEF1; Fri, 12 Sep 2025 10:38:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1757673531; bh=GCR7ls+kXPcQBL7zWMM/aZc/sGBeJxwOiy4URDM1d6s=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=VTPb4rERVDGX25qOL6oRDUnSqsfhjS23UXxuc5AVH/Z8fZ3Go5xtIhTnKH96dCcsO GzpnhF0QxxF+ER5Redy1ftf6SjO6taJlhkutkvmNKgGU1U3rw8jQW+quXNBLYA18FQ HdzjZb/nd5TC8D9iARqkMX/v59ue4rb5vEfl/uhhEiUbbflHxuDtjF04Z+gZYSZTTT HQFHsO5a7XDp1BiRfih0peI9S6WT693idnGgf2uXVAqISX21gZD9LM8Bt2q0O+DCi0 p1AwnZwH26SP75XswCxHJemVMDoXb4qwMRMlxo/TrzB/ds9QqwQwADa/pUEFQgktjX r73DZ5cVPSkQA== Message-ID: <52165346-d752-4203-929e-58dd943cfd7c@kernel.org> Date: Fri, 12 Sep 2025 19:38:49 +0900 Precedence: bulk X-Mailing-List: linux-pci@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] PCI: endpoint: pci-epf-test: NULL check dma channels before release To: Shin'ichiro Kawasaki , linux-pci@vger.kernel.org, Manivannan Sadhasivam , =?UTF-8?Q?Krzysztof_Wilczy=C5=84ski?= , Kishon Vijay Abraham I Cc: Bjorn Helgaas , Frank Li , Niklas Cassel References: <20250912071140.649968-1-shinichiro.kawasaki@wdc.com> Content-Language: en-US From: Damien Le Moal Organization: Western Digital Research In-Reply-To: <20250912071140.649968-1-shinichiro.kawasaki@wdc.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 9/12/25 16:11, Shin'ichiro Kawasaki wrote: > When endpoint controller driver is immature, the fields dma_chan_tx and > dma_chan_rx of the struct pci_epf_test could be NULL even after epf > initialization. However, pci_epf_test_clean_dma_chan() assumes that they > are always non-NULL valid values, and causes kernel panic when the > fields are NULL. To avoid the kernel panic, NULL check the fields before > release. > > Signed-off-by: Shin'ichiro Kawasaki Reviewed-by: Damien Le Moal -- Damien Le Moal Western Digital Research