Linux PCI subsystem development
 help / color / mirror / Atom feed
From: Jiang Liu <liuj97@gmail.com>
To: Bjorn Helgaas <bhelgaas@google.com>
Cc: linux-pci@vger.kernel.org, Yuval Mintz <yuvalmin@broadcom.com>,
	Jacob Keller <jacob.e.keller@intel.com>,
	Jiang Liu <jiang.liu@huawei.com>
Subject: Re: [PATCH 0/4] PCIe Capability accessor fix and cleanups
Date: Thu, 29 Aug 2013 08:41:14 +0800	[thread overview]
Message-ID: <521E98AA.1090308@gmail.com> (raw)
In-Reply-To: <20130828192627.5895.26558.stgit@bhelgaas-glaptop>

On 08/29/2013 03:26 AM, Bjorn Helgaas wrote:
> The first patch fixes a Link Control issue reported by Yuval Mintz.
> The rest simplify the code a bit.
> 
> ---
> 
> Bjorn Helgaas (4):
>       PCI: Allow PCIe Capability link-related register access for switches
>       PCI: Remove PCIe Capability version checks
>       PCI: Support PCIe Capability Slot registers only for ports with slots
>       PCI: Remove pcie_cap_has_devctl()
> 
> 
>  drivers/pci/access.c |   26 +++++++++++---------------
>  1 file changed, 11 insertions(+), 15 deletions(-)
> 
Hi Bjorn,
	Good changes! We avoid some unnecessary hardware accesses for
unavailable registers.

Reviewed-By: Jiang Liu <jiang.liu@huawei.com>

  parent reply	other threads:[~2013-08-29  0:41 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-28 19:26 [PATCH 0/4] PCIe Capability accessor fix and cleanups Bjorn Helgaas
2013-08-28 19:27 ` [PATCH 1/4] PCI: Allow PCIe Capability link-related register access for switches Bjorn Helgaas
2013-08-28 19:27 ` [PATCH 2/4] PCI: Remove PCIe Capability version checks Bjorn Helgaas
2013-08-28 19:27 ` [PATCH 3/4] PCI: Support PCIe Capability Slot registers only for ports with slots Bjorn Helgaas
2013-08-28 19:27 ` [PATCH 4/4] PCI: Remove pcie_cap_has_devctl() Bjorn Helgaas
2013-08-28 20:06 ` [PATCH 0/4] PCIe Capability accessor fix and cleanups Keller, Jacob E
2013-08-29  0:41 ` Jiang Liu [this message]
2013-08-29  3:15   ` Bjorn Helgaas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=521E98AA.1090308@gmail.com \
    --to=liuj97@gmail.com \
    --cc=bhelgaas@google.com \
    --cc=jacob.e.keller@intel.com \
    --cc=jiang.liu@huawei.com \
    --cc=linux-pci@vger.kernel.org \
    --cc=yuvalmin@broadcom.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox