From: Aaron Lu <aaron.lwe@gmail.com>
To: Hans de Bruin <jmdebruin@xmsnet.nl>
Cc: linux-acpi@vger.kernel.org, linux-pci@vger.kernel.org,
Linux-pm mailing list <linux-pm@vger.kernel.org>,
Daniel Lezcano <daniel.lezcano@linaro.org>
Subject: Re: Bisected 3.12.0-rc1 Laptop screen goes blank during kernelboot
Date: Sun, 22 Sep 2013 10:10:49 +0800 [thread overview]
Message-ID: <523E51A9.8050609@gmail.com> (raw)
In-Reply-To: <523C8238.3000200@xmsnet.nl>
Add linux-pm.
-Aaron
On 09/21/2013 01:13 AM, Hans de Bruin wrote:
> During boot time my laptop screen goes blank when de kernel switches the
> screen to another resolution. The backlight is on. Eventually a kde
> login box appears out of the blackness. Swiching to a lower resolution
> gives me a black screen again. After testing the
> intel-gfx@lists.freedesktop.org developers test-tree problem less they
> sugested a bisect. That bisect ended in:
>
>
> commit 137b944e100278d696826cf25c83014ac17473fe
> Author: Daniel Lezcano <daniel.lezcano@linaro.org>
> Date: Wed Jun 12 15:08:48 2013 +0200
>
> cpuidle: Make it clear that governors cannot be modules
>
> cpufreq governors are defined as modules in the code, but the Kconfig
> options do not allow them to be built as modules. This is not really
> a problem, but the cpuidle init ordering is: the cpuidle init
> functions (framework and driver) and then the governors. That leads
> to some weirdness in the cpuidle framework.
>
> Namely, cpuidle_register_device() calls cpuidle_enable_device() which
> fails at the first attempt, because governors have not been registered
> yet. When a governor is registered, the framework calls
> cpuidle_enable_device() again which runs __cpuidle_register_device()
> only then. Of course, for that to work, the cpuidle_enable_device()
> return value has to be ignored by cpuidle_register_device().
>
> Instead of having this cyclic call graph and relying on a positive
> side effects of the hackish back and forth cpuidle_enable_device()
> calls it is better to fix the cpuidle init ordering.
>
> To that end, replace the module init code with postcore_initcall()
> so we have:
>
> * cpuidle framework : core_initcall
> * cpuidle governors : postcore_initcall
> * cpuidle drivers : device_initcall
>
> and remove the corresponding module exit code as it is dead anyway
> (governors can't be built as modules).
>
> [rjw: Changelog]
> Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
>
> :040000 040000 45e7cb28411864c00b62296a7ff239f9f139d5d9
> 86a36b01dee52a77cfbab41a973b7a2bfa44ce34 M drivers
>
>
>
> Reverting it makes the problem go away.
>
next prev parent reply other threads:[~2013-09-22 2:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-20 17:13 Bisected 3.12.0-rc1 Laptop screen goes blank during kernelboot Hans de Bruin
2013-09-22 2:10 ` Aaron Lu [this message]
2013-09-25 12:29 ` Daniel Lezcano
[not found] ` <52447A4C.3020000@xmsnet.nl>
2013-09-27 7:05 ` Daniel Lezcano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=523E51A9.8050609@gmail.com \
--to=aaron.lwe@gmail.com \
--cc=daniel.lezcano@linaro.org \
--cc=jmdebruin@xmsnet.nl \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).