From: Yijing Wang <wangyijing@huawei.com>
To: Ben Hutchings <ben@decadent.org.uk>
Cc: Bjorn Helgaas <bhelgaas@google.com>,
"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
Hanjun Guo <guohanjun@huawei.com>
Subject: Re: [PATCH 2/2] PCI: Warn if power_state != PCI_D0 when write MSI message
Date: Sun, 29 Sep 2013 09:38:17 +0800 [thread overview]
Message-ID: <52478489.8050203@huawei.com> (raw)
In-Reply-To: <1380335308.4430.109.camel@deadeye.wl.decadent.org.uk>
>> I would expect that if the device is not in D0, we should remember the
>> hardware updates that need to be made, and if the device returns to
>> D0, we should apply the updates then. If that's the case this is not
>> an error and we shouldn't warn about it.
> [...]
>
> During system suspend all IRQ affinities are changed to the boot CPU as
> other CPUs are disabled, and then I think they are reverted during
> system resume. This certainly used to be done while most devices were
> suspended. That's why we have to check for the device power state here.
> If suspend/resume is still done in the same order then we shouldn't log
> a warning about this.
>
> Yijing, why not add a check for this in pci_enable_msi() itself if you
> think it's that important to warn about?
This is a good idea, better than just warn a inconspicuous message.
Thanks!
Yijing.
--
Thanks!
Yijing
next prev parent reply other threads:[~2013-09-29 1:38 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-12 8:20 [PATCH 2/2] PCI: Warn if power_state != PCI_D0 when write MSI message Yijing Wang
2013-09-27 21:03 ` Bjorn Helgaas
2013-09-28 2:28 ` Ben Hutchings
2013-09-29 1:38 ` Yijing Wang [this message]
2013-09-29 1:32 ` Yijing Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52478489.8050203@huawei.com \
--to=wangyijing@huawei.com \
--cc=ben@decadent.org.uk \
--cc=bhelgaas@google.com \
--cc=guohanjun@huawei.com \
--cc=linux-pci@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).