Linux PCI subsystem development
 help / color / mirror / Atom feed
From: Arnd Bergmann <arnd@arndb.de>
To: Bjorn Helgaas <helgaas@kernel.org>
Cc: Minghuan Lian <Minghuan.Lian@freescale.com>,
	linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	Zang Roy-R61911 <r61911@freescale.com>,
	Hu Mingkai-B21284 <B21284@freescale.com>,
	Yoder Stuart-B08248 <stuart.yoder@freescale.com>,
	Li Yang <leoli@freescale.com>,
	Bjorn Helgaas <bhelgaas@google.com>,
	Jingoo Han <jg1.han@samsung.com>,
	Zhou Wang <wangzhou1@hisilicon.com>
Subject: Re: [PATCH v2] PCI: layerscape: Add PCIe support for LS1043a and LS2080a
Date: Mon, 12 Oct 2015 14:36:29 +0200	[thread overview]
Message-ID: <5274293.94FcFfK0fd@wuerfel> (raw)
In-Reply-To: <20151007175725.GC27633@localhost>

On Wednesday 07 October 2015 12:57:25 Bjorn Helgaas wrote:
> > diff --git a/drivers/pci/host/Kconfig b/drivers/pci/host/Kconfig
> > index ae873be..38fe8a8 100644
> > --- a/drivers/pci/host/Kconfig
> > +++ b/drivers/pci/host/Kconfig
> > @@ -105,7 +105,7 @@ config PCI_XGENE_MSI
> >  
> >  config PCI_LAYERSCAPE
> >       bool "Freescale Layerscape PCIe controller"
> > -     depends on OF && ARM
> > +     depends on OF && (ARM || ARM64)
> 
> It seems like there are a couple things going on here, and I wonder if
> you can split them out into separate patches.
> 
> 1) Making this work on ARM64 as well as on ARM.  This may be of
> interest for other DesignWare-based drivers, so if you split this out,
> maybe it would be a useful template for converting the other drivers,
> too.

The Kconfig change apparently made it into linux-next now, but it
doesn't actually build on arm64, because the dependency that was
mentioned in the cover letter [0] is not there.

	Arnd


[0] This patch is based on v4.3-rc1 and [PATCH v9 0/6]
PCI: hisi: Add PCIe host support for HiSilicon SoC Hip05
patchset from Zhou Wang.



  parent reply	other threads:[~2015-10-12 12:36 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-17  9:13 [PATCH v2] PCI: layerscape: Add PCIe support for LS1043a and LS2080a Minghuan Lian
2015-10-07 17:57 ` Bjorn Helgaas
2015-10-11 19:10   ` Bjorn Helgaas
2015-10-12  7:15     ` Thomas Petazzoni
2015-10-12 12:36   ` Arnd Bergmann [this message]
2015-10-12 15:26     ` Bjorn Helgaas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5274293.94FcFfK0fd@wuerfel \
    --to=arnd@arndb.de \
    --cc=B21284@freescale.com \
    --cc=Minghuan.Lian@freescale.com \
    --cc=bhelgaas@google.com \
    --cc=helgaas@kernel.org \
    --cc=jg1.han@samsung.com \
    --cc=leoli@freescale.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=r61911@freescale.com \
    --cc=stuart.yoder@freescale.com \
    --cc=wangzhou1@hisilicon.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox