From: Michal Marek <mmarek@suse.cz>
To: linux-kernel@vger.kernel.org
Cc: linux-kbuild@vger.kernel.org, Bjorn Helgaas <bhelgaas@google.com>,
linux-pci@vger.kernel.org, Andi Kleen <ak@linux.intel.com>,
Joe Mario <jmario@redhat.com>
Subject: Re: [PATCH 1/2] PCI: Do not use PCI ID macros in quirk names
Date: Tue, 12 Nov 2013 09:40:29 +0100 [thread overview]
Message-ID: <5281E97D.6090806@suse.cz> (raw)
In-Reply-To: <1384177236-8371-1-git-send-email-mmarek@suse.cz>
On 11.11.2013 14:40, Michal Marek wrote:
> Pasting the verbatim PCI_(VENDOR|DEVICE)_* macros in the __pci_fixup_*
> symbol names results in insanely long names such as
>
> __pci_fixup_resumePCI_VENDOR_ID_SERVERWORKSPCI_DEVICE_ID_SERVERWORKS_HT1000SBquirk_disable_broadcom_boot_interrupt
>
> When LTO adds its numeric suffix to such symbol, it overflows the
> namebuf[KSYM_NAME_LEN] array. Use the line number instead to create
"... the namebuf[KSYM_NAME_LEN] array in kernel/kallsyms.c."
That way, the changelog is hopefully more clear.
Michal
next prev parent reply other threads:[~2013-11-12 8:40 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-11 13:40 [PATCH 1/2] PCI: Do not use PCI ID macros in quirk names Michal Marek
2013-11-12 8:40 ` Michal Marek [this message]
2013-11-25 22:18 ` Bjorn Helgaas
2013-11-25 23:02 ` Andi Kleen
2013-11-25 23:06 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5281E97D.6090806@suse.cz \
--to=mmarek@suse.cz \
--cc=ak@linux.intel.com \
--cc=bhelgaas@google.com \
--cc=jmario@redhat.com \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).